Browse Source

Bug 23805: Update 'lost_item_return' to 'LOST_RETURN' for consistency

Signed-off-by: Kyle Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
remotes/origin/19.11.x
Martin Renvoize 3 years ago
parent
commit
ce479d7a7d
Signed by: martin.renvoize GPG Key ID: 422B469130441A0F
  1. 2
      C4/Circulation.pm
  2. 6
      Koha/Account.pm
  3. 2
      api/v1/swagger/definitions/patron_account_credit.json

2
C4/Circulation.pm

@ -2454,7 +2454,7 @@ sub _FixAccountForLostAndReturned {
$credit = $account->add_credit(
{ amount => $credit_total,
description => 'Item Returned ' . $item_id,
type => 'lost_item_return',
type => 'LOST_RETURN',
interface => C4::Context->interface,
library_id => $branchcode
}

6
Koha/Account.pm

@ -325,7 +325,7 @@ $credit_type can be any of:
- 'CREDIT'
- 'payment'
- 'FORGIVEN'
- 'lost_item_return'
- 'LOST_RETURN'
- 'writeoff'
=cut
@ -718,7 +718,7 @@ sub reconcile_balance {
our $offset_type = {
'CREDIT' => 'Manual Credit',
'FORGIVEN' => 'Writeoff',
'lost_item_return' => 'Lost Item',
'LOST_RETURN' => 'Lost Item',
'payment' => 'Payment',
'writeoff' => 'Writeoff',
'ACCOUNT' => 'Account Fee',
@ -741,7 +741,7 @@ our $offset_type = {
our $account_type_credit = {
'CREDIT' => 'CREDIT',
'FORGIVEN' => 'FORGIVEN',
'lost_item_return' => 'LOST_RETURN',
'LOST_RETURN' => 'LOST_RETURN',
'payment' => 'Pay',
'writeoff' => 'W'
};

2
api/v1/swagger/definitions/patron_account_credit.json

@ -3,7 +3,7 @@
"properties": {
"credit_type": {
"type": "string",
"description": "Type of credit ('CREDIT', 'FORGIVEN', 'lost_item_return', 'payment', 'writeoff' )"
"description": "Type of credit ('CREDIT', 'FORGIVEN', 'LOST_RETURN', 'payment', 'writeoff' )"
},
"amount": {
"type": "number",

Loading…
Cancel
Save