Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34373: Improve layout of curbside pickups items ready list

Browse source 
This patch adds fieldset + list markup around the list of titles ready
for pickup on the staff interface curbside pickup page.

- Properly testing requires testing data. You can run this command to
  REPLACE your curbside pickup data with sample data:

  bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh)
- Apply the patch and restart services.
- Place multiple holds for a single patron and check them in to mark
  them waiting.
- Under Circulation -> Curbside pickups, click the "Schedule pickup"
  tab.
  - Search for the patron you placed the holds for.
  - When the patron information comes up, the list of items ready for
    pickup should be well-formatted.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-07-25 14:29:42 +00:00 committed by Tomas Cohen Arazi
parent b0df1252a9
commit ce8c78c6ba
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt
View file

@ -452,17 +452,19 @@
<li>
<label>Items ready for pickup: </label>
<span>
[% IF waiting_holds.count %]
[% FOREACH h IN waiting_holds %]
<p>
<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% h.biblionumber | uri %]">[% h.biblio.title | html %]</a> ([% h.biblio.author | html %], <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% h.itemnumber | html %]&biblionumber=[% h.biblionumber | html %]#item[% h.itemnumber | html %]">[% h.item.barcode | html %]</a>)
</p>
<fieldset>
<ul>
[% IF waiting_holds.count %]
[% FOREACH h IN waiting_holds %]
<li>
<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% h.biblionumber | uri %]">[% h.biblio.title | html %]</a> ([% h.biblio.author | html %], <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% h.itemnumber | html %]&biblionumber=[% h.biblionumber | html %]#item[% h.itemnumber | html %]">[% h.item.barcode | html %]</a>)
</li>
[% END %]
[% ELSE %]
<li>There are no waiting holds for this patron at this library.</li>
[% END %]
[% ELSE %]
<span>There are no waiting holds for this patron at this library.</span>
[% END %]
</span>
</ul>
</fieldset>
</li>
<li>