Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 6874: (QA followup) Warnings in about page

Browse source 
This patch introduces checks on the about.pl page so the user is warned
for a deficient configuration.

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
This commit is contained in:
Tomás Cohen Arazi 2015-08-07 16:22:22 -03:00 committed by Tomas Cohen Arazi
parent 7f797b3244
commit cef2dd180f
2 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
about.pl
View file

@ -34,6 +34,7 @@ use C4::Context;
use C4::Installer;
use Koha;
use Koha::Config::SysPrefs;
#use Smart::Comments '####';
@ -157,6 +158,19 @@ if ( ! defined C4::Context->config('log4perl_conf') ) {
}
}
if ( ! defined C4::Context->config('upload_path') ) {
if ( Koha::Config::SysPrefs->find('OPACBaseURL')->value ) {
# OPACBaseURL seems to be set
push @xml_config_warnings, {
error => 'uploadpath_entry_missing'
}
} else {
push @xml_config_warnings, {
error => 'uploadpath_and_opacbaseurl_entry_missing'
}
}
}
# Test QueryParser configuration sanity
if ( C4::Context->preference( 'UseQueryParser' ) ) {
# Get the QueryParser configuration file name

15
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
View file

@ -236,6 +236,21 @@
add it, pointing to the log4perl.conf file for your Koha instance.
</td>
</tr>
[% ELSIF config_entry.error == 'uploadpath_entry_missing' %]
<tr>
<th scope="row"><b>Warning</b></th>
<td>You are missing the <strong>&lt;upload_path&gt;</strong> entry in your koha-conf.xml file. Please
add it, pointing to the configured file upload directory for your Koha instance.
</td>
</tr>
[% ELSIF config_entry.error == 'uploadpath_and_opacbaseurl_entry_missing' %]
<tr>
<th scope="row"><b>Warning</b></th>
<td>You are missing the <strong>&lt;upload_path&gt;</strong> entry in your koha-conf.xml file. Please
add it, pointing to the configured file upload directory for your Koha instance.
Also note that you need to properly set the <strong>OPACBaseURL</strong> preference for the file upload plugin to work.
</td>
</tr>
[% END %]
[% END %]
</table>