Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15742: Remove unnecessary loop in j2a cronjob

Browse source 
If no branchcode is given, all the libraries are retrieved and the same
query (so without using the libraries loop) is executed for each
library.

Test plan:
Use the j2a.pl cronjob to change the category of a child patron
If a branchcode is passed to the script, only the children from this
branchcode should be updated.
But if it is not passed, all children of the DB should be updated.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
This commit is contained in:
Jonathan Druart 2016-02-04 13:25:14 +00:00 committed by Brendan Gallagher
parent efad45a0e3
commit cf04724789
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
misc/cronjobs/j2a.pl
View file

@ -130,7 +130,6 @@ if(not $fromcat && $tocat) { #make sure we've specified the info we need.
cronlogaction();
my $dbh=C4::Context->dbh;
my @branches = C4::Branch::GetBranches();
#get today's date, format it and subtract upperagelimit
my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(time);
$year +=1900;
@ -178,7 +177,6 @@ if ( not $noaction) {
} else { print "Updated $res patrons\n"; }
} else { # branch was not supplied, processing all branches
$verbose and print "Looking in all branches for patrons to update from $fromcat to $tocat that were born before $itsyourbirthday\n";
foreach my $branchcode (@branches) {
my $query=qq|UPDATE borrowers
SET guarantorid ='0',
categorycode =?
@ -190,7 +188,6 @@ if ( not $noaction) {
if ($res eq '0E0') { print "No patrons updated\n";
} else { print "Updated $res patrons\n"; }
}
}
} else {
my $birthday;
if ( $mybranch ) {