Bug 2505 - remove unnecessary -w and replace with use warnings;

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

installer/externalmodules.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
 # This Script can be used to provide a list of ALL external modules ***used*** (uncommented) in Koha.
 # It provides you not only the list of modules BUT ALSO the files that uses those modules.
@@ -6,6 +6,7 @@
 
 
 use strict;
+use warnings;
 use C4::Context;
 my $dir=C4::Context->config('intranetdir');
 qx(grep -r "^ *use" $dir | grep -v "C4\|strict\|vars" >/tmp/modulesKoha.log);

misc/cronjobs/advance_notices.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
 # Copyright 2008 LibLime
 #

misc/cronjobs/cleanup_database.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
 # Copyright 2009 PTFS, Inc.
 #

misc/cronjobs/create_koc_db.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
 # 2008 Kyle Hall <kyle.m.hall@gmail.com>
 

misc/cronjobs/longoverdue.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 #-----------------------------------
 # Copyright 2008 LibLime
 #

misc/cronjobs/overdue_notices.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
 # Copyright 2008 Liblime
 #

misc/cronjobs/process_message_queue.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
 # Copyright 2008 LibLime
 #

misc/cronjobs/runreport.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 #
 # Copyright 2008 Liblime
 #

misc/cronjobs/serialsUpdate.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 
 # Copyright 2008 SARL Biblibre
 #

misc/cronjobs/stats/monthly_circulation_statistics.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 #-----------------------------------
 # Script Name: circstats.pl
 # Script Version: 1.0
@@ -30,6 +30,7 @@
 # Suite 330, Boston, MA  02111-1307 USA
 
 # use strict;
+use warnings;
 
 # UNCOMMENT the following lines if running from a command line
 # print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) ";

misc/cronjobs/stats/monthly_new_items_statistics.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 #-----------------------------------
 # Script Name: addstats.pl
 # Script Version: 1.0
@@ -29,6 +29,8 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+use warnings;
+
 # UNCOMMENT the following lines if running from a command line
 # print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) ";
 # chomp($_ = <STDIN>);

misc/cronjobs/stats/monthly_new_patron_statistics.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 #-----------------------------------
 # Script Name: borrstats.pl
 # Script Version: 1.0
@@ -30,6 +30,7 @@
 # Suite 330, Boston, MA  02111-1307 USA
 
 # use strict;
+use warnings;
 
 # UNCOMMENT the following lines if running from a command line
 # print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) ";

misc/maintenance/fix_accountlines_date.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 #
 # Copyright (C) 2008 LibLime
 #
@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+use warnings;
 BEGIN {
     # find Koha's Perl modules
     # test carefully before changing this

misc/perlmodule_rm.pl

@@ -1,5 +1,8 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
+
 # Remove a perl module
+
+use warnings;
 use ExtUtils::Packlist;
 use ExtUtils::Installed;
 

misc/spellcheck_suggest/make_spellcheck_suggest.pl

@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl
 ## This Script creates a Koha suggest and spellcheck database
 ## for those features as visible on LibLime's opac: opac.liblime.com
 ## It also contains the needed specs for creating a table of
@@ -14,6 +14,8 @@
 ## TODO: add suggest features, merge the two of them?
 ## There are a few configurable variables.  
 
+use warnings;
+
 ## CONFIGURABLE VARIABLES ####################
 ##
  # These are the tags that have meaningful data