Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 22607: Change default value in issues.renewals to '0'.

Browse source 
This patch change renewals column of issues and old_issues tables.

Now it is NOT NULL default 0. It does not make sense when number of
renewals is undefined, it is always integer with value zero or more

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Josef Moravec 2019-03-29 08:13:48 +00:00 committed by Nick Clemens
parent a5fcd93f72
commit cf95f0a7e6
2 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
installer/data/mysql/atomicupdate/Bug22607_set_issues_renewals_default_to_zero.perl Normal file
View file

@ -0,0 +1,13 @@
$DBversion = 'XXX'; # will be replaced by the RM
if( CheckVersion( $DBversion ) ) {
$dbh->do( "UPDATE issues SET renewals = 0 WHERE renewals IS NULL" );
$dbh->do( "UPDATE old_issues SET renewals = 0 WHERE renewals IS NULL" );
$dbh->do( "ALTER TABLE issues MODIFY COLUMN renewals tinyint(4) NOT NULL default 0");
$dbh->do( "ALTER TABLE old_issues MODIFY COLUMN renewals tinyint(4) NOT NULL default 0");
# Always end with this (adjust the bug info)
SetVersion( $DBversion );
print "Upgrade to $DBversion done (Bug XXXXX - Set default value of issues.renewals to 0)\n";
}

4
installer/data/mysql/kohastructure.sql
View file

@ -1727,7 +1727,7 @@ CREATE TABLE `issues` ( -- information related to check outs or issues
`branchcode` varchar(10) default NULL, -- foreign key, linking to the branches table for the location the item was checked out
`returndate` datetime default NULL, -- date the item was returned, will be NULL until moved to old_issues
`lastreneweddate` datetime default NULL, -- date the item was last renewed
`renewals` tinyint(4) default NULL, -- lists the number of times the item was renewed
`renewals` tinyint(4) NOT NULL default 0, -- lists the number of times the item was renewed
`auto_renew` BOOLEAN default FALSE, -- automatic renewal
`auto_renew_error` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, -- automatic renewal error
`timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- the date and time this record was last touched
@ -1759,7 +1759,7 @@ CREATE TABLE `old_issues` ( -- lists items that were checked out and have been r
`branchcode` varchar(10) default NULL, -- foreign key, linking to the branches table for the location the item was checked out
`returndate` datetime default NULL, -- date the item was returned
`lastreneweddate` datetime default NULL, -- date the item was last renewed
`renewals` tinyint(4) default NULL, -- lists the number of times the item was renewed
`renewals` tinyint(4) NOT NULL default 0, -- lists the number of times the item was renewed
`auto_renew` BOOLEAN default FALSE, -- automatic renewal
`auto_renew_error` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, -- automatic renewal error
`timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- the date and time this record was last touched