Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37478: Rename strict to skip_bad_records and add POD

Browse source 
Option name changed, POD updated.
The reason not to do this by default is that it is an extra record conversion
to check the validity, so may slow down the import.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Nick Clemens 2024-10-31 19:23:08 +00:00 committed by Katrin Fischer
parent 43fd84508d
commit cfb72ca7fa
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 43 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

80
misc/migration_tools/bulkmarcimport.pl
View file

@ -77,45 +77,45 @@ my $localcust;
my $marc_mod_template = ''; my $marc_mod_template = '';
my $marc_mod_template_id = -1; my $marc_mod_template_id = -1;
my $skip_indexing = 0; my $skip_indexing = 0;
my $strict_mode; my $skip_bad_records;
$| = 1; $| = 1;
GetOptions( GetOptions(
'commit:f' => \$commit, 'commit:f' => \$commit,
'file:s' => \$input_marc_file, 'file:s' => \$input_marc_file,
'n:f' => \$number, 'n:f' => \$number,
'o|offset:f' => \$offset, 'o|offset:f' => \$offset,
'h|help' => \$version, 'h|help' => \$version,
'd|delete' => \$delete, 'd|delete' => \$delete,
't|test' => \$test_parameter, 't|test' => \$test_parameter,
's' => \$skip_marc8_conversion, 's' => \$skip_marc8_conversion,
'c:s' => \$char_encoding, 'c:s' => \$char_encoding,
'v|verbose:+' => \$verbose, 'v|verbose:+' => \$verbose,
'fk' => \$fk_off, 'fk' => \$fk_off,
'm:s' => \$format, 'm:s' => \$format,
'l:s' => \$logfile, 'l:s' => \$logfile,
'append' => \$append, 'append' => \$append,
'k|keepids:s' => \$keepids, 'k|keepids:s' => \$keepids,
'b|biblios' => \$biblios, 'b|biblios' => \$biblios,
'a|authorities' => \$authorities, 'a|authorities' => \$authorities,
'authtypes:s' => \$authtypes, 'authtypes:s' => \$authtypes,
'filter=s@' => \$filters, 'filter=s@' => \$filters,
'insert' => \$insert, 'insert' => \$insert,
'update' => \$update, 'update' => \$update,
'all' => \$all, 'all' => \$all,
'match=s@' => \$match, 'match=s@' => \$match,
'i|isbn' => \$isbn_check, 'i|isbn' => \$isbn_check,
'x:s' => \$sourcetag, 'x:s' => \$sourcetag,
'y:s' => \$sourcesubfield, 'y:s' => \$sourcesubfield,
'idmap:s' => \$idmapfl, 'idmap:s' => \$idmapfl,
'cleanisbn!' => \$cleanisbn, 'cleanisbn!' => \$cleanisbn,
'yaml:s' => \$yamlfile, 'yaml:s' => \$yamlfile,
'dedupbarcode' => \$dedup_barcode, 'dedupbarcode' => \$dedup_barcode,
'framework=s' => \$framework, 'framework=s' => \$framework,
'custom:s' => \$localcust, 'custom:s' => \$localcust,
'marcmodtemplate:s' => \$marc_mod_template, 'marcmodtemplate:s' => \$marc_mod_template,
'si|skip_indexing' => \$skip_indexing, 'si|skip_indexing' => \$skip_indexing,
'st|strict' => \$strict_mode, 'sk|skip_bad_records' => \$skip_bad_records,
); );
$biblios ||= !$authorities; $biblios ||= !$authorities;
@ -343,7 +343,7 @@ RECORD: while () {
} }
if ($record) { if ($record) {
if ($strict_mode) { if ($skip_bad_records) {
my $xml = $record->as_xml_record(); my $xml = $record->as_xml_record();
eval { MARC::Record::new_from_xml( $xml, 'UTF-8', "MARC21" ); }; eval { MARC::Record::new_from_xml( $xml, 'UTF-8', "MARC21" ); };
if ($@) { if ($@) {
@ -1046,6 +1046,12 @@ If set, do not index the imported records with Zebra or Elasticsearch.
Use this when you plan to do a complete reindex of your data after running Use this when you plan to do a complete reindex of your data after running
bulkmarciport. This can increase performance and avoid unnecessary load. bulkmarciport. This can increase performance and avoid unnecessary load.
=item B<-sk, --skip_bad_records>
If set, check the validity of records before adding. If they are invalid we will
print the output of MARC::Lint->check_record and skip them during the import. Without
this option bad records may kill the job.
=back =back
=cut =cut