Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 2617: Add strict (and warnings), partial fix.

Browse source 
These are some of the simpler scripts to add strict to.
Corrected perldoc for Bookfund.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
This commit is contained in:
Joe Atzberger 2009-03-10 16:41:00 -05:00 committed by Henri-Damien LAURENT
parent b446c28804
commit d0370b1144
6 changed files with 38 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
C4/Bookfund.pm
View file

@ -315,11 +315,13 @@ sub NewBookFund{
=head3 ModBookFund =head3 ModBookFund
&ModBookFund($bookfundname,$bookfundid,$current_branch, $branchcode) = &ModBookFund($bookfundname,$bookfundid,$current_branch, $branchcode)
this function update the bookfundname and the branchcode on aqbookfund table on database.
This function updates the bookfundname and the branchcode in the aqbookfund table.
=cut =cut
# FIXME: use placeholders, ->prepare(), ->execute()
sub ModBookFund { sub ModBookFund {
my ($bookfundname,$bookfundid,$current_branch, $branchcode) = @_; my ($bookfundname,$bookfundid,$current_branch, $branchcode) = @_;
@ -349,8 +351,6 @@ sub ModBookFund {
} }
} }
#-------------------------------------------------------------# #-------------------------------------------------------------#
=head3 SearchBookFund =head3 SearchBookFund

25
acqui/currency.pl
View file

@ -1,11 +1,9 @@
#!/usr/bin/perl #!/usr/bin/perl
#written by chris@katipo.co.nz #written by chris@katipo.co.nz
#9/10/2000 #9/10/2000
#script to display and update currency rates #script to display and update currency rates
# Copyright 2000-2002 Katipo Communications # Copyright 2000-2002 Katipo Communications
# #
# This file is part of Koha. # This file is part of Koha.
@ -23,18 +21,21 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA # Suite 330, Boston, MA 02111-1307 USA
use strict;
use warnings;
use CGI; use CGI;
use C4::Acquisition; use C4::Bookfund qw(ModCurrencies);
use C4::Biblio;
use C4::Bookfund;
my $input=new CGI; # FIXME: CHECK AUTH
# FIXME: This should be part of another script, not a throwaway standalone.
# FIXME: params should have better checks before passed to ModCurrencies
# FIXME: need error handling if ModCurrencies FAILS.
my @params=$input->param; my $input = new CGI;
foreach my $param (@params){
if ($param ne 'type' && $param !~ /submit/){ foreach my $param ($input->param) {
my $data=$input->param($param); if ($param ne 'type' && $param !~ /submit/) {
ModCurrencies($param,$data); ModCurrencies($param, $input->param($param));
} }
} }
print $input->redirect('/cgi-bin/koha/acqui/acqui-home.pl'); print $input->redirect('/cgi-bin/koha/acqui/acqui-home.pl');

2
admin/env_tz_test.pl
View file

@ -1,5 +1,7 @@
#!/usr/bin/perl #!/usr/bin/perl
use strict;
use warnings;
use CGI; use CGI;
# use Data::Dumper; # use Data::Dumper;

5
changelanguage.pl
View file

@ -15,7 +15,10 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA # Suite 330, Boston, MA 02111-1307 USA
use C4::Output; use strict;
use warnings;
use C4::Output qw(setlanguagecookie);
use CGI; use CGI;
my $query = new CGI; my $query = new CGI;

14
misc/sax_parser_print.pl
View file

@ -1,6 +1,14 @@
#!/usr/bin/perl #!/usr/bin/perl
# check the current SAX Parser # check the current SAX Parser
use XML::SAX::ParserFactory;
$parser = XML::SAX::ParserFactory->parser();
print "$parser\n";
use strict;
use warnings;
use XML::SAX::ParserFactory;
my $parser = XML::SAX::ParserFactory->parser();
print "Koha wants something like:
XML::LibXML::SAX::Parser=HASH(0x81fe220)
You have:
$parser\n";
print "Looks " .
($parser =~ /^XML::LibXML::SAX::Parser=HASH/ ?
"good.\n" : "bad, check INSTALL.* documentation.\n");

6
opac/opac-changelanguage.pl
View file

@ -15,12 +15,14 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA # Suite 330, Boston, MA 02111-1307 USA
use C4::Output; use strict;
use warnings;
use C4::Output qw(setlanguagecookie);
use CGI; use CGI;
my $query = new CGI; my $query = new CGI;
my $language = $query->param('language'); my $language = $query->param('language');
my $url = $query->referer(); my $url = $query->referer();
warn "Language : $query // $language // $url"; # warn "Language : $query // $language // $url";
setlanguagecookie( $query, $language, $url ); setlanguagecookie( $query, $language, $url );