Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37812: (QA follow-up) Prevent cypress test failures by correcting modal selector, removing ambiguity of contains calls, replace by get with respective ids

Browse source 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Paul Derscheid 2024-09-19 15:17:43 +00:00 committed by Martin Renvoize
parent a5702bb71a
commit d09ef98b85
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
t/cypress/integration/Preservation/Trains.ts
View file

@ -532,7 +532,7 @@ describe("Trains", () => {
cy.get("#barcode").type("bc_1");
cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
cy.contains("Submit").click();
cy.get("div[class='alert alert-warning modal']").contains(
cy.get("div[class='modal']").contains(
"Cannot find item with this barcode. It must be in the waiting list."
);
cy.get("#close_modal").click();
@ -632,7 +632,7 @@ describe("Trains", () => {
cy.get("#waiting-list").contains("Add to waiting list").click();
cy.get("#barcode_list").type("bc_1\nbc_2");
cy.contains("Submit").click();
cy.contains("Save").click();
cy.wait("@get-items");
cy.get("main div[class='alert alert-info']").contains(
"2 new items added."
@ -640,9 +640,9 @@ describe("Trains", () => {
cy.get("#waiting-list").contains("Add to waiting list").click();
cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
cy.contains("Submit").click();
cy.contains("Save").click();
cy.wait("@get-items");
cy.get("main div[class='alert alert-warning modal']").contains(
cy.get("main div[class='modal']").contains(
"2 new items added. 1 items not found."
);
cy.get("#close_modal").click();
@ -668,7 +668,7 @@ describe("Trains", () => {
});
}
);
cy.contains("Submit").click(); // Select train
cy.get("#add_to_train .approve").click();
train.items = get_train_items().filter(
train_item => train_item.item_id == 1 || train_item.item_id == 2
);

6
t/cypress/integration/Preservation/WaitingList.ts
View file

@ -76,7 +76,7 @@ describe("WaitingList", () => {
});
cy.get("#waiting-list").contains("Add to waiting list").click();
cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
cy.contains("Submit").click();
cy.get("#add_to_waiting_list .approve").click();
cy.get("main div[class='alert alert-warning']").contains(
"Something went wrong: Error: Internal Server Error"
);
@ -95,9 +95,9 @@ describe("WaitingList", () => {
]);
cy.get("#waiting-list").contains("Add to waiting list").click();
cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
cy.contains("Submit").click();
cy.get("#add_to_waiting_list .approve").click();
cy.wait("@get-items");
cy.get("main div[class='alert alert-warning modal']").contains(
cy.get("main div[class='modal']").contains(
"2 new items added. 1 items not found."
);
});