Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21983: Make DelBiblio update linked ILL requests

Browse source 
This patch makes DelBiblio update the biblio linked ILL requests so the
value in biblio_id is moved to the deleted_biblio_id.

The change is covered by tests.

To test:
1. Apply this patchset
2. Run:
   $ ktd --shell
  k$ updatedatabase
  k$ qa --run-tests
=> SUCCESS: Tests pass! All green/good
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Tomás Cohen Arazi 2023-06-05 13:54:40 -03:00
parent f1cd3a44b0
commit d235937259
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/Biblio.pm
View file

@ -523,6 +523,8 @@ sub DelBiblio {
# We update any existing orders
my $orders = $biblio->orders;
$orders->update({ deleted_biblionumber => $biblionumber}, { no_triggers => 1 });
# Update related ILL requests
$biblio->ill_requests->update({ deleted_biblio_id => $biblio->id, biblio_id => undef });
unless ( $params->{skip_record_index} ){
my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });

13
t/db_dependent/Biblio.t
View file

@ -670,7 +670,7 @@ subtest 'deletedbiblio_metadata' => sub {
subtest 'DelBiblio' => sub {
plan tests => 6;
plan tests => 10;
t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
@ -716,11 +716,22 @@ subtest 'DelBiblio' => sub {
my $order = $builder->build_object(
{ class => 'Koha::Acquisition::Orders', value => $orderinfo } );
# Add some ILL requests
my $ill_req_1 = $builder->build_object({ class => 'Koha::Illrequests', value => { biblio_id => $biblio->id, deleted_biblio_id => undef } });
my $ill_req_2 = $builder->build_object({ class => 'Koha::Illrequests', value => { biblio_id => $biblio->id, deleted_biblio_id => undef } });
C4::Biblio::DelBiblio($biblio->biblionumber); # Or $biblio->delete
is( $subscription->get_from_storage, undef, 'subscription should be deleted on biblio deletion' );
is( $serial->get_from_storage, undef, 'serial should be deleted on biblio deletion' );
is( $subscription_history->get_from_storage, undef, 'subscription history should be deleted on biblio deletion' );
is( $order->get_from_storage->deleted_biblionumber, $biblio->biblionumber, 'biblionumber of order has been moved to deleted_biblionumber column' );
$ill_req_1 = $ill_req_1->get_from_storage;
$ill_req_2 = $ill_req_2->get_from_storage;
is( $ill_req_1->biblio_id, undef, 'biblio_id cleared on biblio deletion' );
is( $ill_req_1->deleted_biblio_id, $biblio->id, 'biblio_id is kept on the deleted_biblio_id column' );
is( $ill_req_2->biblio_id, undef, 'biblio_id cleared on biblio deletion' );
is( $ill_req_2->deleted_biblio_id, $biblio->id, 'biblio_id is kept on the deleted_biblio_id column' );
};
subtest 'MarcFieldForCreatorAndModifier' => sub {