Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21238: Prevent TemplateToolkit.t to fail on slow servers

Browse source 
It failed 3x in the last 6 runs (on node 1), we should mock
DateTime->now to prevent it to fail again.

The error is:
koha_1       |         #   Failed test at
t/db_dependent/Letters/TemplateToolkit.t line 724.

When comparing <<today>> replacement:
koha_1       |         # 08/16/2018 14:25<br />
[...]
koha_1       |         # 08/16/2018 14:24<br />

Let's mock DateTime->now to prevent it to fail again.

Test plan:
0. Do not apply this patch
1. Add "sleep(60);" at line ~715, before "# Add a second checkout"
2. Run the tests
=> Fail!
3. Apply this patch
4. Run the tests again
=> Pass!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2018-08-16 12:29:43 -03:00 committed by Nick Clemens
parent cb5bf46dc7
commit d24d77d495
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
t/db_dependent/Letters/TemplateToolkit.t
View file

@ -20,6 +20,7 @@
use Modern::Perl;
use Test::More tests => 18;
use Test::MockModule;
use Test::Warn;
use MARC::Record;
@ -56,7 +57,9 @@ $dbh->{RaiseError} = 1;
$dbh->do(q|DELETE FROM letter|);
my $date = dt_from_string;
my $now_value = DateTime->now();
my $mocked_datetime = Test::MockModule->new('DateTime');
$mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
my $library = $builder->build( { source => 'Branch' } );
my $patron = $builder->build( { source => 'Borrower' } );