Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 7368: Removing occurrences of dependant= feature in javascript open calls

Browse source 
The window feature dependant= should have been written as dependent=
Note that this feature is ignored in most/current browsers.
Since the feature was misspelled, removing it will not change any
behavior or hurt anybody.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
Marcel de Rooy 2012-11-12 13:17:04 +01:00 committed by Jared Camins-Esakov
parent 90ddc20c07
commit d3b50910da
5 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/includes/virtualshelves-toolbar.inc
View file

@ -15,11 +15,11 @@
});
[% IF ( viewshelf ) %] function sendList(){
open(CGIBIN+'virtualshelves/sendshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
open(CGIBIN+'virtualshelves/sendshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
}
function downloadList(){
open(CGIBIN+'virtualshelves/downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
open(CGIBIN+'virtualshelves/downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
}[% END %]
// YUI Toolbar Functions

6
koha-tmpl/intranet-tmpl/prog/en/js/basket.js
View file

@ -79,7 +79,7 @@ function openBasket() {
if ( strCookie ) {
var iW = 820;
var iH = 450;
var optWin = "dependant=yes,status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
var optWin = "status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
var loc = CGIBIN + "basket/basket.pl?" + strCookie;
var basket = open(loc, "basket", optWin);
if (window.focus) {basket.focus()}
@ -335,7 +335,7 @@ function sendBasket() {
var loc = CGIBIN + "basket/sendbasket.pl?" + strCookie;
var optWin="dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
var optWin="scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
var win_form = open(loc,"win_form",optWin);
}
@ -345,7 +345,7 @@ function downloadBasket() {
var loc = CGIBIN + "basket/downloadcart.pl?" + strCookie;
open(loc,"win_form",'dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
open(loc,"win_form",'scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
}
function printBasket() {

6
koha-tmpl/opac-tmpl/ccsr/en/js/basket.js
View file

@ -80,7 +80,7 @@ function openBasket() {
if ( strCookie ) {
var iW = 820;
var iH = 450;
var optWin = "dependant=yes,status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
var optWin = "status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
var loc = CGIBIN + "opac-basket.pl?" + strCookie;
var basket = open(loc, "basket", optWin);
if (window.focus) {basket.focus()}
@ -354,7 +354,7 @@ function sendBasket() {
var loc = CGIBIN + "opac-sendbasket.pl?" + strCookie;
var optWin="dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
var optWin="scrollbars=no,resizable=no,height=300,width=450,top=50,left=100";
var win_form = open(loc,"win_form",optWin);
}
@ -365,7 +365,7 @@ function downloadBasket() {
var loc = CGIBIN + "opac-downloadcart.pl?" + strCookie;
open(loc,"win_form",'dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
open(loc,"win_form",'scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
}
function printBasket() {

4
koha-tmpl/opac-tmpl/prog/en/js/basket.js
View file

@ -80,7 +80,7 @@ function openBasket() {
if ( strCookie ) {
var iW = 820;
var iH = 450;
var optWin = "dependant=yes,status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
var optWin = "status=yes,scrollbars=yes,resizable=yes,toolbar=no,location=yes,height="+iH+",width="+iW;
var loc = CGIBIN + "opac-basket.pl?" + strCookie;
var basket = open(loc, "basket", optWin);
if (window.focus) {basket.focus()}
@ -365,7 +365,7 @@ function downloadBasket() {
var loc = CGIBIN + "opac-downloadcart.pl?" + strCookie;
open(loc,"win_form",'dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
open(loc,"win_form",'scrollbars=no,resizable=no,height=300,width=450,top=50,left=100');
}
function printBasket() {

4
koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
View file

@ -261,9 +261,9 @@ $(function() {
[% IF ( itemsloop ) %]
<div id="toolbar" class="list-actions">
<a href="/cgi-bin/koha/opac-downloadshelf.pl?shelfid=[% shelfnumber %]" class="download" onclick="open(CGIBIN+'opac-downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false;">Download list</a>
<a href="/cgi-bin/koha/opac-downloadshelf.pl?shelfid=[% shelfnumber %]" class="download" onclick="open(CGIBIN+'opac-downloadshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false;">Download list</a>
[% IF ( opacuserlogin ) %]<span class="sendlist"><a href="/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber %]" class="send" onclick="open(CGIBIN+'opac-sendshelf.pl?shelfid=[% shelfnumber %]','win_form','dependant=yes,scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false; ">Send list</a></span>[% END %]
[% IF ( opacuserlogin ) %]<span class="sendlist"><a href="/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber %]" class="send" onclick="open(CGIBIN+'opac-sendshelf.pl?shelfid=[% shelfnumber %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false; ">Send list</a></span>[% END %]
<a class="print" href="opac-shelves.pl" onclick="print(); return false;">Print list</a>