Browse Source

Bug 27738: Set fallback for unset DefaultCountryField008 to |||, "no attempt to code"

Current code intended to set a fallback of xxu, an unknown state in the US,
but because the preference is always defined, just sometimes unset, it
actually falls back to three spaces, an invalid value. This patch instead
uses the fallback value ||| which means no attempt to code.

Test plan:
1. Without the patch, verify that the value of the system preference
DefaultCountryField008 is empty.
2. Cataloging - New record - Default framework (if you have the Advanced
editor enabled, Settings - Switch to basic editor, this only applies to the
basic editor)
3. On tab 0, click in the text input for field 008 which fills in default
values, then click the Tag editor button at the end of the field
4. In the popup window, verify that the value for 15-17 is shown as ###
indicating three spaces
5. Apply patch, repeat the steps above, verify that the value is now |||

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
master
Phil Ringnalda 1 month ago
parent
commit
d5e7d37d8a
2 changed files with 3 additions and 2 deletions
  1. +2
    -1
      cataloguing/value_builder/marc21_field_008.pl
  2. +1
    -1
      koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref

+ 2
- 1
cataloguing/value_builder/marc21_field_008.pl View File

@@ -36,7 +36,8 @@ my $builder = sub {
my $lang = C4::Context->preference('DefaultLanguageField008' );
$lang = "eng" unless $lang;
$lang = pack("A3", $lang);
my $country = C4::Context->preference('DefaultCountryField008') // "xxu";
my $country = C4::Context->preference('DefaultCountryField008');
$country = "|||" unless $country;
$country = pack("A3", $country);

my $function_name = $params->{id};


+ 1
- 1
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref View File

@@ -63,7 +63,7 @@ Cataloging:
-
- "Fill in the default country code for field 008 Range 15-17 of MARC21 - Place of publication, production, or execution. (See <a href='http://www.loc.gov/marc/countries/countries_code.html'>MARC Code List for Countries</a>):"
- pref: DefaultCountryField008
- " Empty defaults to xxu for United States."
- " Empty defaults to ||| for No attempt to code."
-
- Interpret and store MARC records in the
- pref: marcflavour


Loading…
Cancel
Save