Browse Source

Bug 22540: (QA follow-up) fixes

borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is
via hashref

Add ability to specify the pickup location using a command line
parameter

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
remotes/origin/19.11.x
Kyle Hall 4 years ago
committed by Martin Renvoize
parent
commit
d66432cafd
Signed by: martin.renvoize GPG Key ID: 422B469130441A0F
  1. 2
      C4/SIP/ILS/Transaction/Hold.pm
  2. 17
      misc/sip_cli_emulator.pl

2
C4/SIP/ILS/Transaction/Hold.pm

@ -54,7 +54,7 @@ sub do_hold {
$self->ok(0);
return $self;
}
my $branch = ( $self->pickup_location || $self->{patron}->branchcode );
my $branch = ( $self->pickup_location || $self->{patron}->{branchcode} );
unless ($branch) {
$self->screen_msg('No branch specified (or found w/ patron).');
$self->ok(0);

17
misc/sip_cli_emulator.pl

@ -52,6 +52,7 @@ my $currency_type;
my $fee_amount;
my $fee_identifier;
my $transaction_id;
my $pickup_location;
my $terminator = q{};
@ -73,12 +74,13 @@ GetOptions(
"s|summary=s" => \$summary,
"fee-type=s" => \$fee_type,
"payment-type=s" => \$payment_type,
"currency-type=s" => \$currency_type,
"fee-amount=s" => \$fee_amount,
"fee-identifier=s" => \$fee_identifier,
"transaction-id=s" => \$transaction_id,
"fee-type=s" => \$fee_type,
"payment-type=s" => \$payment_type,
"currency-type=s" => \$currency_type,
"fee-amount=s" => \$fee_amount,
"fee-identifier=s" => \$fee_identifier,
"transaction-id=s" => \$transaction_id,
"pickup-location=s" => \$pickup_location,
"t|terminator=s" => \$terminator,
@ -265,7 +267,7 @@ my $handlers = {
hold_mode => '+',
transaction_date => $transaction_date,
expiration_date => undef,
pickup_location => undef,
pickup_location => $pickup_location,
hold_type => undef,
institution_id => $location_code,
patron_identifier => $patron_identifier,
@ -636,6 +638,7 @@ Options:
--fee-amount Fee amount for Fee Paid message, required
--fee-identifier Fee identifier for Fee Paid message, optional
--transaction-id Transaction id for Fee Paid message, optional
--pickup-location Pickup location (branchcode) for Hold message, optional
-m --message SIP2 message to execute

Loading…
Cancel
Save