Bug 16852: Remove GetBorrowerCategorycode
And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
parent
b3f9232b6a
commit
d6de78624e
2 changed files with 3 additions and 25 deletions
|
@ -78,8 +78,6 @@ BEGIN {
|
|||
&GetMemberAccountRecords
|
||||
&GetBorNotifyAcctRecord
|
||||
|
||||
GetBorrowerCategorycode
|
||||
|
||||
&GetBorrowersToExpunge
|
||||
&GetBorrowersWhoHaveNeverBorrowed
|
||||
&GetBorrowersWithIssuesHistoryOlderThan
|
||||
|
@ -522,7 +520,7 @@ sub ModMember {
|
|||
}
|
||||
}
|
||||
|
||||
my $old_categorycode = GetBorrowerCategorycode( $data{borrowernumber} );
|
||||
my $old_categorycode = Koha::Patrons->find( $data{borrowernumber} )->categorycode;
|
||||
|
||||
# get only the columns of a borrower
|
||||
my $schema = Koha::Database->new()->schema;
|
||||
|
@ -1213,26 +1211,6 @@ sub GetUpcomingMembershipExpires {
|
|||
return $results;
|
||||
}
|
||||
|
||||
=head2 GetBorrowerCategorycode
|
||||
|
||||
$categorycode = &GetBorrowerCategoryCode( $borrowernumber );
|
||||
|
||||
Given the borrowernumber, the function returns the corresponding categorycode
|
||||
|
||||
=cut
|
||||
|
||||
sub GetBorrowerCategorycode {
|
||||
my ( $borrowernumber ) = @_;
|
||||
my $dbh = C4::Context->dbh;
|
||||
my $sth = $dbh->prepare( qq{
|
||||
SELECT categorycode
|
||||
FROM borrowers
|
||||
WHERE borrowernumber = ?
|
||||
} );
|
||||
$sth->execute( $borrowernumber );
|
||||
return $sth->fetchrow;
|
||||
}
|
||||
|
||||
=head2 GetAge
|
||||
|
||||
$dateofbirth,$date = &GetAge($date);
|
||||
|
|
|
@ -38,6 +38,7 @@ use Koha::DateUtils qw( dt_from_string );
|
|||
use Koha::List::Patron;
|
||||
use Koha::Libraries;
|
||||
use Koha::Patron::Categories;
|
||||
use Koha::Patrons;
|
||||
|
||||
my $input = new CGI;
|
||||
my $op = $input->param('op') || 'show_form';
|
||||
|
@ -294,8 +295,7 @@ if ( $op eq 'do' ) {
|
|||
}
|
||||
}
|
||||
|
||||
#
|
||||
my $borrower_categorycode = GetBorrowerCategorycode $borrowernumber;
|
||||
my $borrower_categorycode = Koha::Patrons->find( $borrowernumber )->categorycode;
|
||||
my $i=0;
|
||||
for ( @attributes ) {
|
||||
my $attribute;
|
||||
|
|
Loading…
Reference in a new issue