Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31041: Prevent duplicate display of cashup summary when printing

Browse source 
To test:
1. Have POS on.
2. Have some registers and items for sale. Make some sales to 'Cashup'.
3. If you have enough enough lines in the table so that 'register.pl' would print on 2 or more pages, the summary will be duplicated that same number of time.

If you are lazy like me and don't want to make that many transaction you can also add some content to the page like this:

for (let i = 0; i < 100; i++) {
  $('#register').append('<h1>TEST</h1>');
}

4. APPLY PATCH, clear browser cahche
5. Try printing again, you should only get one cashup summary when printing.

Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 85fb62f3d6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Lucas Gass 2023-11-02 19:56:00 +00:00 committed by Fridolin Somers
parent fc11755571
commit d74cec9612
1 changed files with 41 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
koha-tmpl/intranet-tmpl/prog/js/cashup_modal.js
View file

@ -55,6 +55,46 @@ $(document).ready(function() {
});
$('.printModal').click(function() {
window.print();
let contents = $('#cashupSummaryModal .modal-body').html();
let win = window.open('','');
win.document.write(`
<style>
table {
background-color: #FFFFFF;
border-bottom: 1px solid #CCCCCC;
border-collapse: collapse;
border-left: 1px solid #CCCCCC;
margin: 3px 0 5px 0;
padding: 0;
width: 99%;
}
td {
background-color: #FFF;
border-bottom: 1px solid #CCCCCC;
border-left: 0;
border-right: 1px solid #CCCCCC;
border-top: 0;
font-size: 12px;
padding: 5px 5px 5px 5px;
}
th {
background-color: #E9E9E9;
border-bottom: 1px solid #CCCCCC;
border-left: 0;
border-right: 1px solid #CCCCCC;
border-top: 0;
font-size: 14px;
font-weight: bold;
padding: 5px 5px 5px 5px;
text-align: left;
}
</style>
`)
win.document.write( contents );
win.print();
win.close();
});
});