Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24052: Catch warning between test 5 and 6

Browse source 
Resolve:
ok 5 - Engine returns error on undefined text
XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214.
ok 6 - Engine returns error on empty string

Test plan:
Run perl Base.t and verify that this warning is no longer printed.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2020-02-25 15:09:53 +00:00 committed by Martin Renvoize
parent fc2c8c3767
commit d77a65fe7a
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
t/db_dependent/Koha/XSLT/Base.t
View file

@ -20,7 +20,7 @@
use Modern::Perl;
use File::Temp qw/tempfile/;
use Test::More tests => 32;
use Test::More tests => 33;
use Test::Warn;
use Koha::XSLT::Base;
@ -70,7 +70,9 @@ $output = $engine->transform({ xml => undef, code => $xsl_1 });
is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_7, 'Engine returns error on undefined text' );
# Empty string tests
$output = $engine->transform({ xml => '', code => $xsl_1 });
warning_like {$output = $engine->transform({ xml => '', code => $xsl_1 }) }
qr/XSLT::Base: Empty String/,
'Empty string warning detected';
is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_5, 'Engine returns error on empty string' );
# Non-XML tests