From d7c0547bd20bd266ea8cd023ac4be22c2a9644d0 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 26 Feb 2019 16:32:44 -0300
Subject: [PATCH] Bug 21846: Fix pod2usage return values

According to existing pattern.
However I am not sure it makes sense to return an errno (and print to STDERR)
if --help is passed.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 misc/maintenance/fix_tags_weight.pl | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/misc/maintenance/fix_tags_weight.pl b/misc/maintenance/fix_tags_weight.pl
index 549d170614..7dc3801c16 100755
--- a/misc/maintenance/fix_tags_weight.pl
+++ b/misc/maintenance/fix_tags_weight.pl
@@ -65,15 +65,12 @@ binmode( STDOUT, ":encoding(UTF-8)" );
 my $help;
 my $verbose;
 
-my $result = GetOptions(
+GetOptions(
     'help|h'    => \$help,
     'verbose|v' => \$verbose
-);
+) or pod2usage(2);
 
-if ( not $result or $help ) {
-    pod2usage();
-    exit 0;
-}
+pod2usage(1) if $help;
 
 fix_tags_approval($verbose);
 fix_tags_index( $verbose );