Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27519: Normalize Show/Don't show in system preferences

Browse source 
Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences.

Test plan:
1- Go to administration > system preferences
2- View any system preference with Display/Don't display pair of options
(e.g. OPACAcquisitionDetails)
3- Apply the patch
4- Refresh the page and notice it is now a Show/Don't show pair instead
5- Loop the steps with other system preferences until satisfied

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit ed81d6bac6)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Shi Yao Wang 2022-05-18 10:59:39 -04:00 committed by Lucas Gass
parent f99bad2f36
commit d7fc581e62
6 changed files with 37 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
View file

@ -35,12 +35,12 @@ Administration:
1: Some 1: Some
2: All 2: All
- -
- "Show itemtype icons in the staff interface: "
- pref: noItemTypeImages - pref: noItemTypeImages
default: 0 default: 0
choices: choices:
1: "No" 1: "Don't show"
0: "Yes" 0: "Show"
- "itemtype icons in the staff interface."
- -
- "Default separator for columns in an exported CSV file: " - "Default separator for columns in an exported CSV file: "
- pref: CSVDelimiter - pref: CSVDelimiter

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref
View file

@ -4,8 +4,8 @@ Authorities:
- pref: AuthDisplayHierarchy - pref: AuthDisplayHierarchy
default: no default: no
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- broader term/narrower term hierarchies when viewing authorities. - broader term/narrower term hierarchies when viewing authorities.
- -
- Use the following text to edit how authority records control indicators of attached bibliographic fields (and possibly subfield $2).<br> - Use the following text to edit how authority records control indicators of attached bibliographic fields (and possibly subfield $2).<br>

20
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
View file

@ -9,14 +9,14 @@ Cataloging:
- -
- pref: advancedMARCeditor - pref: advancedMARCeditor
choices: choices:
1: "Don't display" 1: "Don't show"
0: Display 0: Show
- descriptions of fields and subfields in the MARC editor. - descriptions of fields and subfields in the MARC editor.
- -
- pref: EasyAnalyticalRecords - pref: EasyAnalyticalRecords
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- "easy ways to create analytical record relationships." - "easy ways to create analytical record relationships."
- -
- pref: EnableAdvancedCatalogingEditor - pref: EnableAdvancedCatalogingEditor
@ -59,8 +59,8 @@ Cataloging:
- -
- pref: SpineLabelShowPrintOnBibDetails - pref: SpineLabelShowPrintOnBibDetails
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- buttons on the bibliographic details page to print item spine labels. - buttons on the bibliographic details page to print item spine labels.
- -
Record structure: Record structure:
@ -192,8 +192,8 @@ Cataloging:
- -
- pref: hide_marc - pref: hide_marc
choices: choices:
1: "Don't display" 1: "Don't show"
0: Display 0: Show
- MARC tag numbers, subfield codes and indicators in MARC views. - MARC tag numbers, subfield codes and indicators in MARC views.
- -
- pref: LabelMARCView - pref: LabelMARCView
@ -255,8 +255,8 @@ Cataloging:
- -
- pref: AcquisitionDetails - pref: AcquisitionDetails
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- acquisition details on the bibliographic record detail page. - acquisition details on the bibliographic record detail page.
- -
- "Show the following fields for deleted records after a merge:" - "Show the following fields for deleted records after a merge:"

16
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
View file

@ -286,14 +286,14 @@ Enhanced content:
- -
- pref: LocalCoverImages - pref: LocalCoverImages
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- local cover images on staff interface search and details pages. - local cover images on staff interface search and details pages.
- -
- pref: OPACLocalCoverImages - pref: OPACLocalCoverImages
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- local cover images on OPAC search and details pages. - local cover images on OPAC search and details pages.
- -
- pref: AllowMultipleCovers - pref: AllowMultipleCovers
@ -304,13 +304,13 @@ Enhanced content:
- -
- pref: CustomCoverImages - pref: CustomCoverImages
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- "custom remote URL images in the staff interface.<br/>" - "custom remote URL images in the staff interface.<br/>"
- pref: OPACCustomCoverImages - pref: OPACCustomCoverImages
choices: choices:
1: Display 1: Show
0: "Don't display" 0: "Don't show"
- "custom remote URL images at the OPAC.<br/>" - "custom remote URL images at the OPAC.<br/>"
- "Using the following URL:" - "Using the following URL:"
- pref: CustomCoverImagesURL - pref: CustomCoverImagesURL

24
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
View file

@ -102,12 +102,12 @@ OPAC:
class: file class: file
- '<br />Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTDetailsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li><li>NOTE: The system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PassItemMarcToXSLT">PassItemMarcToXSLT</a> must be enabled if your custom stylesheet utilizes data in the item fields</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.' - '<br />Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTDetailsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li><li>NOTE: The system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PassItemMarcToXSLT">PassItemMarcToXSLT</a> must be enabled if your custom stylesheet utilizes data in the item fields</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
- -
- "Show itemtype icons in the OPAC: "
- pref: OpacNoItemTypeImages - pref: OpacNoItemTypeImages
default: 0 default: 0
choices: choices:
1: "No" 1: "Don't show"
0: "Yes" 0: "Show"
- "itemtype icons in the OPAC."
- -
- pref: DisplayOPACiconsXSLT - pref: DisplayOPACiconsXSLT
choices: choices:
@ -449,7 +449,7 @@ OPAC:
- pref: ShowReviewerPhoto - pref: ShowReviewerPhoto
choices: choices:
1: Show 1: Show
0: Hide 0: Don't show
- reviewer's avatar beside comments in OPAC. The avatar will be searched on <a href="https://www.libravatar.org" target="_blank">Libravatar</a> using the patron's e-mail address. - reviewer's avatar beside comments in OPAC. The avatar will be searched on <a href="https://www.libravatar.org" target="_blank">Libravatar</a> using the patron's e-mail address.
- -
- pref: OPACHoldRequests - pref: OPACHoldRequests
@ -490,8 +490,8 @@ OPAC:
- pref: OPACPopupAuthorsSearch - pref: OPACPopupAuthorsSearch
default: 0 default: 0
choices: choices:
1: Display 1: Show
0: Don't display 0: Don't show
- the list of authors/subjects in a popup for a combined search on OPAC detail pages. - the list of authors/subjects in a popup for a combined search on OPAC detail pages.
- -
- pref: OpacHoldNotes - pref: OpacHoldNotes
@ -504,15 +504,15 @@ OPAC:
- pref: OPACAcquisitionDetails - pref: OPACAcquisitionDetails
default: 0 default: 0
choices: choices:
1: Display 1: Show
0: Don't display 0: Don't show
- the acquisition details on OPAC detail pages. - the acquisition details on OPAC detail pages.
- -
- pref: OpacNewsLibrarySelect - pref: OpacNewsLibrarySelect
default: 0 default: 0
choices: choices:
1: Display 1: Show
0: Don't display 0: Don't show
- a library selection list for news items in the OPAC. - a library selection list for news items in the OPAC.
- -
- pref: OPACSuggestionAutoFill - pref: OPACSuggestionAutoFill
@ -841,8 +841,8 @@ OPAC:
- -
- pref: PatronSelfRegistrationPrefillForm - pref: PatronSelfRegistrationPrefillForm
choices: choices:
1: "Display and prefill" 1: "Show and prefill"
0: "Don't display and prefill" 0: "Don't show and prefill"
- "password and login form after a patron has self registered." - "password and login form after a patron has self registered."
- -
- pref: PatronSelfRegistrationConfirmEmail - pref: PatronSelfRegistrationConfirmEmail

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
View file

@ -272,8 +272,8 @@ Searching:
- -
- pref: BiblioItemtypeInfo - pref: BiblioItemtypeInfo
choices: choices:
1: "Display" 1: "Show"
0: "Don't display" 0: "Don't show"
- ' Koha record level itemtype info on detail and result pages in the OPAC and staff interface. This info also displays if the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=item-level_itypes">item-level_itypes</a> system preference is set to bibliographic record.' - ' Koha record level itemtype info on detail and result pages in the OPAC and staff interface. This info also displays if the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=item-level_itypes">item-level_itypes</a> system preference is set to bibliographic record.'
- -
- pref: PassItemMarcToXSLT - pref: PassItemMarcToXSLT