Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29100: (QA follow-up) Rename issue(s) keys to checkout(s)

Browse source 
Adapted test plan:

1) Apply this patch
2) For DUE and PREDUE notices, set the message body to the following:
   Title: [% checkout.title %]
3) For DUEDGST and PREDUEDGST notices, set the message body to the following:
   Titles:
   [% FOREACH c IN checkouts %]
    * [% c.title %][% END %]
4) Generate PREDUE and DUE notices for patrons including digests
5) Verify those notices contain the checkout titles

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: tcohen renamed @issues => @checkouts as well
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Kyle Hall 2022-11-15 06:57:44 -05:00 committed by Tomas Cohen Arazi
parent fd7a612c6e
commit d81bca8270
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
misc/cronjobs/advance_notices.pl
View file

@ -306,7 +306,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
itemnumber => $upcoming->{'itemnumber'},
substitute => {
'items.content' => $title,
issue => $item_info,
checkout => $item_info,
},
message_transport_type => $transport,
} )
@ -355,7 +355,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) {
itemnumber => $upcoming->{'itemnumber'},
substitute => {
'items.content' => $title,
issue => $item_info,
checkout => $item_info,
},
message_transport_type => $transport,
} )
@ -595,10 +595,10 @@ sub send_digests {
});
my $titles = "";
my @itemnumbers;
my @issues;
my @checkouts;
while ( my $item_info = $next_item_info->()) {
push @itemnumbers, $item_info->{itemnumber};
push( @issues, $item_info );
push( @checkouts, $item_info );
$titles .= C4::Letters::get_item_content( { item => $item_info, item_content_fields => \@item_content_fields } );
}
@ -608,11 +608,11 @@ sub send_digests {
{
letter_code => $params->{letter_code},
borrowernumber => $borrowernumber,
issues => \@issues,
checkouts => \@checkouts,
substitute => {
count => $count,
'items.content' => $titles,
issues => \@issues,
checkouts => \@checkouts,
%branch_info
},
itemnumbers => \@itemnumbers,