Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23227: Remove type attribute from script tags: Reports

Browse source 
This patch removes the "type" attribute from <script> tags in two
reports templates.

To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:

 - Reports -> Dictionary
   - Delete
   - Specifying a date range for a date column
 - Reports -> Items lost
   - Report results
     -> Datatables functionality
     -> Selection tools for export

Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Owen Leonard 2019-06-27 13:38:50 +00:00 committed by Martin Renvoize
parent 0658d84732
commit d88709ec2d
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt
View file

@ -273,7 +273,7 @@
[% MACRO jsinclude BLOCK %] [% MACRO jsinclude BLOCK %]
[% INCLUDE 'calendar.inc' %] [% INCLUDE 'calendar.inc' %]
<script type="text/javascript"> <script>
var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this dictionary definition? This cannot be undone."); var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this dictionary definition? This cannot be undone.");
$(document).ready(function() { $(document).ready(function() {

2
koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
View file

@ -192,7 +192,7 @@
[% INCLUDE 'columns_settings.inc' %] [% INCLUDE 'columns_settings.inc' %]
[% Asset.js("js/table_filters.js") | $raw %] [% Asset.js("js/table_filters.js") | $raw %]
[% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
<script type='text/javascript'> <script>
$(document).ready(function() { $(document).ready(function() {
var columns_settings = [% ColumnsSettings.GetColumns( 'reports', 'lostitems', 'lostitems-table', 'json' ) | $raw %]; var columns_settings = [% ColumnsSettings.GetColumns( 'reports', 'lostitems', 'lostitems-table', 'json' ) | $raw %];
var lostitems_table = KohaTable("lostitems-table", { var lostitems_table = KohaTable("lostitems-table", {