Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 24432: Regresion test

Browse source 
To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t

Test should fail at this point.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Agustin Moyano 2020-01-15 19:52:53 -03:00 committed by Martin Renvoize
parent 7015ba7059
commit d8bd366b5c
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
t/Koha/REST/Plugin/Query.t
View file

@ -22,6 +22,7 @@ use Mojolicious::Lite;
use Try::Tiny;
use Koha::Cities;
use Koha::Holds;
app->log->level('error');
@ -108,6 +109,20 @@ get '/dbic_merge_sorting_result_set' => sub {
$c->render( json => $attributes, status => 200 );
};
get '/dbic_merge_sorting_date' => sub {
my $c = shift;
my $attributes = { a => 'a', b => 'b' };
my $result_set = Koha::Holds->new;
$attributes = $c->dbic_merge_sorting(
{
attributes => $attributes,
params => { _match => 'exact', _order_by => [ '-hold_date' ] },
result_set => $result_set
}
);
$c->render( json => $attributes, status => 200 );
};
get '/build_query' => sub {
my $c = shift;
my ( $filtered_params, $reserved_params ) =
@ -214,7 +229,7 @@ subtest 'extract_reserved_params() tests' => sub {
subtest 'dbic_merge_sorting() tests' => sub {
plan tests => 15;
plan tests => 20;
my $t = Test::Mojo->new;
@ -240,6 +255,14 @@ subtest 'dbic_merge_sorting() tests' => sub {
]
);
$t->get_ok('/dbic_merge_sorting_date')->status_is(200)
->json_is( '/a' => 'a', 'Existing values are kept (a)' )
->json_is( '/b' => 'b', 'Existing values are kept (b)' )->json_is(
'/order_by' => [
{ -desc => 'reservedate' }
]
);
$t->get_ok('/dbic_merge_sorting_single')->status_is(200)
->json_is( '/a' => 'a', 'Existing values are kept (a)' )
->json_is( '/b' => 'b', 'Existing values are kept (b)' )->json_is(