From d92f033cfc6bcee3d6bea1925c9de13c56d55def Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 18 Aug 2023 10:40:49 +0000 Subject: [PATCH] Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header This patch makes changes to the patron attribute types administration template so that the page title, breadcrumb navigation, and page headers are more consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Patron attribute types. Test these versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New patron attribute type - Edit patron attribute type - Confirm deletion of attribute type Signed-off-by: Christian Nelson Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- .../prog/en/modules/admin/patron-attr-types.tt | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt index 2129798b31..0251a18309 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt @@ -10,9 +10,9 @@ [% FILTER collapse %] [% IF ( attribute_type_form ) %] [% IF ( edit_attribute_type ) %] - [% t("Modify patron attribute type") | html %] › + [% tx("Modify patron attribute type '{code}'", { code = attribute_type.code }) | html %] › [% ELSE %] - [% t("Add patron attribute type") | html %] › + [% t("New patron attribute type") | html %] › [% END %] [% END %] [% IF ( delete_attribute_type_form ) %] @@ -45,15 +45,15 @@ [% IF ( attribute_type_form ) %] [% WRAPPER breadcrumb_item bc_active= 1 %] [% IF ( edit_attribute_type ) %] - <span>Modify patron attribute type</span> + [% tx("Modify patron attribute type '{code}'", { code = attribute_type.code }) | html %] [% ELSE %] - <span>Add patron attribute type</span> + <span>New patron attribute type</span> [% END %] [% END %] [% ELSIF ( delete_attribute_type_form ) %] [% WRAPPER breadcrumb_item bc_active= 1 %] - <span>Confirm deletion of patron attribute type '[% code | html %]'</span> + [% tx("Confirm deletion of patron attribute type '{code}'", { code = code }) | html %] [% END %] [% ELSE %] @@ -75,9 +75,9 @@ [% IF ( attribute_type_form ) %] [% IF ( edit_attribute_type ) %] -<h1>Modify patron attribute type</h1> +<h1>[% tx("Modify patron attribute type '{code}'", { code = attribute_type.code }) | html %]</h1> [% ELSE %] -<h1>Add patron attribute type</h1> +<h1>New patron attribute type</h1> [% END %] [% IF ( duplicate_code_error ) %] <div class="dialog message">Could not add patron attribute type "[% duplicate_code_error | html %]" @@ -247,7 +247,9 @@ [% IF ( delete_attribute_type_form ) %] <div class="dialog alert"> - <h1>Confirm deletion of patron attribute type <span class="ex">'[% code | html %]' ([% description | html %])</span>?</h1> + <h1> + [% tx("Confirm deletion of patron attribute type '{code}' ({description})?", { code = code, description = description }) | html %] + </h1> <form action="[% script_name | html %]" name="Aform" method="post"> <input type="hidden" name="op" value="[% confirm_op | html %]" /> <input type="hidden" name="code" value="[% code | html %]" />