Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 38986: Restore Any in fund dropdown on suggestions homepage

Browse source 
This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion

To test:
1 - have two suggestions, one with a fund assigned and one without
2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option
3 - apply patch, reload page
4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly
5 - confirm you cannot select Any when creating a new suggestion

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>

Bug 38986: Restore Any option to suggestions homepage filter

"Any" should show all suggestions, any fund value and null fund values. One should not be able to create a suggeestion set to "Any"
"None" should show only suggestions with no fund value selected. A new suggestion should default to "None"

To Test:
1: have two suggestions, one with a fund selected and one without
2: go to suggestions homepage, confirm the filter does not have an "Any" option
3: apply patch, reload page
4: confirm the fund filter on suggestion homepage now has both Any and None and they behave as described above
5: confirm the fund filter defaults to Any as you change the branch filter
6: create a new suggestion, confirm its fund defaults to None and cannot be set to Any

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Andrew Fuerste-Henry 2025-02-03 18:13:26 +00:00 committed by Katrin Fischer
parent 20eb3d0a2e
commit da6996c08e
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
View file

@ -1335,14 +1335,13 @@
[% BLOCK funds_dropdown %]
<label for="budgetid">Fund:</label>
<select name="budgetid" id="budgetid">
[% IF op == 'save' %]
[% UNLESS op == 'save' %]
<option value="">Any</option>
[% END %]
[% IF budgetid == '__NONE__' %]
<option value="__NONE__" selected="selected">None</option>
[% ELSE %]
[% IF budgetid == '__NONE__' %]
<option value="__NONE__" selected="selected">None</option>
[% ELSE %]
<option value="__NONE__">None</option>
[% END %]
<option value="__NONE__">None</option>
[% END %]
[% FOREACH budget IN sugg_budgets %]
[% IF ( budget.selected ) %]