Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32999: Click handler to show QR code in OPAC lacks preventDefault

Browse source 
This patch adds "preventDefault()" to the click handler for showing
the bibliographic detail QR code. This prevents the page from scrolling
to the top when the user clicks the link.

To test, apply the patch and make sure the OPACDetailQRCode system
preference is enabled.

Locate a bibliographic record and view the detail page. If necessary,
reduce the size of your browser window so that you have to scroll down
a bit to bring the "Send to device" menu item into view in the sidebar.
Click the link to confirm that it shows the QR code and that the page
doesn't jump to the top.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5ba3eea495)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Owen Leonard 2023-02-17 16:07:36 +00:00 committed by Martin Renvoize
parent e2344b96e8
commit db04e01f66
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
View file

@ -1680,7 +1680,8 @@
document.getElementById("qrcode").appendChild( qrcode );
}
$(".show_qrcode").on("click", function(){
$(".show_qrcode").on("click", function(e){
e.preventDefault();
var qrcodeImg = $("#qrcode");
if( qrcodeImg.hasClass("d-none") ){
qrcodeImg.removeClass("d-none");