Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23109: Improve description of staffaccess permission

Browse source 
Changes:
Allow staff members to modify permissions for other staff members
To:
Allow staff members to modify permissions and passwords for other staff members.

As suggested by Andre on the initial bug report.

To test:
- Go to any patron account and check More > permissions
- Veriy the description is shown as noted above
- Apply patch and run database update
- Reload the page and verify the description has changed
- Run the following SQL and verify the description in the
  database table matches as well:

SELECT * FROM userflags where flag = "staffaccess";

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Katrin Fischer 2019-06-17 21:50:01 +00:00 committed by Martin Renvoize
parent 9f4c2306eb
commit dc0e8002fa
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
3 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
installer/data/mysql/atomicupdate/bug_23109_improve_staffaccess_description.perl Normal file
View file

@ -0,0 +1,6 @@
$DBversion = 'XXX'; # will be replaced by the RM
if( CheckVersion( $DBversion ) ) {
$dbh->do( "UPDATE userflags SET flagdesc = 'Allow staff members to modify permissions and passwords for other staff members' WHERE flag = 'staffaccess'" );
SetVersion( $DBversion );
print "Upgrade to $DBversion done (Bug 23109 - Improve description of staffacess permissiony)\n";
}

2
installer/data/mysql/userflags.sql
View file

@ -13,7 +13,7 @@ INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES
(14,'editauthorities','Edit authorities',0),
(15,'serials','Manage serial subscriptions',0),
(16,'reports','Allow access to the reports module',0),
(17,'staffaccess','Allow staff members to modify permissions for other staff members',0),
(17,'staffaccess','Allow staff members to modify permissions and passwords for other staff members',0),
(18,'coursereserves','Course reserves',0),
(19, 'plugins', 'Koha plugins', '0'),
(20, 'lists', 'Lists', 0),

2
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
View file

@ -43,7 +43,7 @@
<span class="main_permission reports_permission">Allow access to the reports module</span>
<span class="permissioncode">([% name | html %])</span>
[%- CASE 'staffaccess' -%]
<span class="main_permission staffaccess_permission">Allow staff members to modify permissions for other staff members</span>
<span class="main_permission staffaccess_permission">Allow staff members to modify permissions and passwords for other staff members</span>
<span class="permissioncode">([% name | html %])</span>
[%- CASE 'coursereserves' -%]
<span class="main_permission coursereserves_permission">Course reserves</span>