Bug 35078: Remove invalid HTML from OpacShowSavings system preference

The options defined for the OpacShowSavings system preference contain
HTML: "on patron's checkout history page (the system preference
<em>opacreadinghistory</em> must be enabled)". This text ends up in an
<option> tag, and even though the form is rendered using the
multiple-select plugin the HTML still won't render and should
be removed.

To test, apply the patch and restart all.

- Go to Administration -> System preferences and search for
  "OpacShowSavings"
- Check the dropdown of options on the preference. The system
  preference names referred to should now be single-quoted instead of
  wrapped in visible <em> tags.
- Confirm that the preference still works correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref

@@ -547,8 +547,8 @@ OPAC:
             - "Calculate the amount a patron has 'saved' by using the library based on replacement prices, and display:"
             - pref: OPACShowSavings
               multiple:
-                  checkouthistory: "on patron's checkout history page (the system preference <em>opacreadinghistory</em> must be enabled)"
-                  summary: "in user summary box on OPAC homepage (the system preference <em>OPACUserSummary</em> must be enabled)"
+                  checkouthistory: "on patron's checkout history page (the system preference 'opacreadinghistory' must be enabled)"
+                  summary: "in user summary box on OPAC homepage (the system preference 'OPACUserSummary' must be enabled)"
                   user: "on patron's 'your summary' page"
             - ". Note that displayed savings may be inaccurate if checkout history is anonymized."
     OpenURL: