bug 3881: remove unused OpacPrivacy syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

admin/systempreferences.pl

@@ -110,7 +110,6 @@ $tabsysprefs{noOPACUserLogin}       = "Admin";
 $tabsysprefs{'OAI-PMH:ConfFile'}    = "Admin";
 $tabsysprefs{OpacAddMastheadLibraryPulldown}    = "Admin";
 $tabsysprefs{opaclargeimage}        = "Admin";
-$tabsysprefs{OpacPrivacy}           = "Admin";
 $tabsysprefs{OPACXSLTDetailsDisplay}    = "Admin";
 $tabsysprefs{OPACXSLTResultsDisplay}    = "Admin";
 $tabsysprefs{PDFFontType}           = "Admin";

installer/data/mysql/updatedatabase.pl

@@ -4,7 +4,7 @@
 # Database Updater
 # This script checks for required updates to the database.
 
-# Part of the Koha Library Software www.koha.org
+# Part of the Koha Library Software www.koha-community.org
 # Licensed under the GPL.
 
 # Bugs/ToDo:
@@ -3776,6 +3776,13 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
     SetVersion ($DBversion);
 }
 
+$DBversion = "3.02.00.002";
+if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
+    $dbh->do(q{DELETE FROM systempreferences WHERE variable = 'OpacPrivacy'});
+    print "Upgrade to $DBversion done (bug 3881: remove unused OpacPrivacy system preference)\n";
+    SetVersion ($DBversion);
+}
+
 =item DropAllForeignKeys($table)
 
   Drop all foreign keys of the table $table

koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref

@@ -299,10 +299,3 @@ OPAC:
                   yes: Keep
                   no: "Don't keep"
             - patron search history in the OPAC.
-        -
-            - pref: OpacPrivacy
-              default: 0
-              choices:
-                  yes: Allow
-                  no: "Don't allow"
-            - patrons to opt-in/opt-out of saving their reading/circulation history.

kohaversion.pl

@@ -10,7 +10,7 @@
 use strict;
 
 sub kohaversion {
-    our $VERSION = '3.02.00.001';
+    our $VERSION = '3.02.00.002';
     # version needs to be set this way
     # so that it can be picked up by Makefile.PL
     # during install