Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 13253 - Unnecessary white space above checkouts table in circulation

Browse source 
On the new checkouts page there is some padding above the checkouts,
relatives' checkouts, and holds tables caused by extra markup in the
table's sDom configuration (http://legacy.datatables.net/ref#sDom):

<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t

This creates several empty <div>s which don't serve any purpose. This
patch simplifies it to:

rt

To test, apply the patch, clear your browser cache, and check out to a
patron who has items checked out, holds on their account, and child
records attached which also have checkouts.

The padding above the table of checkouts, the table of relatives'
checkouts, and the table of holds should match that on the sides.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Checked per plan on both Check Out and Details pages, spacing appears correct.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Owen Leonard 2014-11-13 20:15:22 -05:00 committed by Tomas Cohen Arazi
parent 9e07b59d5b
commit dd385fc2e9
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
View file

@ -156,7 +156,7 @@ $(document).ready(function() {
"sEmptyTable" : MSG_DT_LOADING_RECORDS,
},
"bAutoWidth": false,
"sDom": "<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t",
"sDom": "rt",
"aoColumns": [
{
"mDataProp": function( oObj ) {
@ -398,7 +398,7 @@ $(document).ready(function() {
if ( ! relativesIssuesTable ) {
relativesIssuesTable = $("#relatives-issues-table").dataTable({
"bAutoWidth": false,
"sDom": "<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t",
"sDom": "rt",
"aaSorting": [],
"aoColumns": [
{

2
koha-tmpl/intranet-tmpl/prog/en/js/holds.js
View file

@ -5,7 +5,7 @@ $(document).ready(function() {
if ( ! holdsTable ) {
holdsTable = $("#holds-table").dataTable({
"bAutoWidth": false,
"sDom": "<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t",
"sDom": "rt",
"aoColumns": [
{
"mDataProp": "reservedate_formatted"