Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23463: Fix safe_return return value in deletion tools

Browse source 
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2020-01-30 16:15:14 +01:00 committed by Martin Renvoize
parent 57eb6e4226
commit de9ce93cf2
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/batchMod.pl
View file

@ -191,7 +191,7 @@ if ($op eq "action") {
my $itemdata = $item->unblessed; my $itemdata = $item->unblessed;
if ( $del ){ if ( $del ){
my $return = $item->safe_delete; my $return = $item->safe_delete;
if ($return == 1) { if (ref($return)) {
$deleted_items++; $deleted_items++;
} else { } else {
$not_deleted_items++; $not_deleted_items++;

4
tools/batch_delete_records.pl
View file

@ -177,8 +177,8 @@ if ( $op eq 'form' ) {
# Delete items # Delete items
my $items = Koha::Items->search({ biblionumber => $biblionumber }); my $items = Koha::Items->search({ biblionumber => $biblionumber });
while ( my $item = $items->next ) { while ( my $item = $items->next ) {
my $error = eval { $item->safe_delete }; my $deleted_item = eval { $item->safe_delete };
if ( $error ne '1' or $@ ) { if ( !ref($deleted_item) or $@ ) {
push @messages, { push @messages, {
type => 'error', type => 'error',
code => 'item_not_deleted', code => 'item_not_deleted',