Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34678: Unit test

Browse source 
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This commit is contained in:
Nick Clemens 2023-09-13 17:01:09 +00:00 committed by Tomas Cohen Arazi
parent b9ea3eb988
commit dfad12d079
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
t/db_dependent/Reserves.t
View file

@ -1764,7 +1764,7 @@ subtest 'DefaultHoldExpiration tests' => sub {
};
subtest '_Findgroupreserves' => sub {
plan tests => 4;
plan tests => 6;
$schema->storage->txn_begin;
my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } );
@ -1791,8 +1791,8 @@ subtest '_Findgroupreserves' => sub {
C4::HoldsQueue::AddToHoldTargetMap(
{
$item->id => {
borrowernumber => $patron_1->id, biblionumber => $item->biblionumber,
holdingbranch => $item->holdingbranch, item_level => 0, reserve_id => $reserve_id_1
borrowernumber => $patron_1->id, biblionumber => $item->biblionumber,
holdingbranch => $item->holdingbranch, item_level => 0, reserve_id => $reserve_id_1
}
}
);
@ -1816,6 +1816,22 @@ subtest '_Findgroupreserves' => sub {
is( scalar @reserves, 1, "We should only get the item level hold that is in the map" );
is( $reserves[0]->{reserve_id}, $reserve_id_2, "We got the expected reserve" );
C4::HoldsQueue::AddToHoldTargetMap(
{
$item_2->id => {
borrowernumber => $patron_2->id, biblionumber => $item->biblionumber,
holdingbranch => $item->holdingbranch, item_level => 1, reserve_id => $reserve_id_1
}
}
);
# When the hold is title level and in the hold fill targets we expect this to be the only hold returned
@reserves = C4::Reserves::_Findgroupreserve( $item->biblionumber, $item_2->id, 0, [] );
is( scalar @reserves, 1, "We should still only get the item level hold that is in the map" );
is( $reserves[0]->{reserve_id}, $reserve_id_1, "We got the expected reserve which has been updated" );
$schema->txn_rollback;
};