Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33445: Pass through form info if present and use record values otherwise

Browse source 
This patch updates the form to pass through values formthe form when searching, and
to use record values if nothing is passed in.

TO test:
 1 - Without the patch, edit a personal name authority record
 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name
 3 - Click "Replace record via Z39.50/SRU search"
 4 - Note that prefilled search field contains the original value, not your name.
 5 - Replace the Author (personal) field with your name in the search form
 6 - choose a search target, and click Search.
 7 - Note that the results of the search are for the original value, not your name
 8 - From the details page of a record, click 'Edit -> Replace record via Z3950'
 9 - Note form is prefilled
10 - Change value as in 5 and search
11 - Note original term was searched
12 - Apply patch, restart all
13 - Repeat searches as before
14 - Confirm that form is prefilled with record or the updated value
15 - Confirm your entered search terms are always searched

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 44e868f464)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Nick Clemens 2023-04-28 12:39:58 +00:00 committed by Matt Blenkinsop
parent e35e1b5869
commit e0077548da
1 changed files with 24 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
cataloguing/z3950_auth_search.pl
View file

@ -33,6 +33,7 @@ my $input = CGI->new;
my $dbh = C4::Context->dbh;
my $error = $input->param('error');
my $authid = $input->param('authid') || 0;
my $op = $input->param('op')||'';
my $record = GetAuthority($authid);
my $marc_flavour = C4::Context->preference('marcflavour');
@ -44,34 +45,31 @@ my $authfields_mapping = {
'subject' => $marc_flavour eq 'MARC21' ? '150' : '250',
};
my $nameany = $input->param('nameany');
my $authorany = $input->param('authorany');
my $authorcorp =
$record
? $record->subfield( $authfields_mapping->{'authorcorp'}, 'a' )
: $input->param('authorcorp');
my $authorpersonal =
$record
? $record->subfield( $authfields_mapping->{'authorpersonal'}, 'a' )
: $input->param('authorpersonal');
my $authormeetingcon =
$record
? $record->subfield( $authfields_mapping->{'authormeetingcon'}, 'a' )
: $input->param('authormeetingcon');
my $nameany = $input->param('nameany');
my $authorany = $input->param('authorany');
my $title = $input->param('title');
my $authorpersonal = $input->param('authorpersonal');
my $authormeetingcon = $input->param('authormeetingcon');
my $uniformtitle = $input->param('uniformtitle');
my $subject = $input->param('subject');
my $authorcorp = $input->param('authorcorp');
my $subjectsubdiv = $input->param('subjectsubdiv');
my $srchany = $input->param('srchany');
my $title = $input->param('title');
my $uniformtitle =
$record
? $record->subfield( $authfields_mapping->{'uniformtitle'}, 'a' )
: $input->param('uniformtitle');
my $subject =
$record
? $record->subfield( $authfields_mapping->{'subject'}, 'a' )
: $input->param('subject');
# If replacing an existing record we want to initially populate the form with record info,
# however, we want to use entered inputs when searching
if ( $record && $op ne 'do_search' ) {
$authorcorp ||=
$record->subfield( $authfields_mapping->{'authorcorp'}, 'a' );
$authorpersonal ||=
$record->subfield( $authfields_mapping->{'authorpersonal'}, 'a' );
$authormeetingcon ||=
$record->subfield( $authfields_mapping->{'authormeetingcon'}, 'a' );
$uniformtitle ||=
$record->subfield( $authfields_mapping->{'uniformtitle'}, 'a' );
$subject ||= $record->subfield( $authfields_mapping->{'subject'}, 'a' );
}
my $subjectsubdiv = $input->param('subjectsubdiv');
my $srchany = $input->param('srchany');
my $op = $input->param('op')||'';
my $page = $input->param('current_page') || 1;
my $index =$input->param('index');
$page = $input->param('goto_page') if $input->param('changepage_goto');