Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31994: DataTable next button does not work when using data in the HTML

Browse source 
This patch resolves the issue that occurs when the next button of a DataTable with data straight from the HTML is clicked.

Test plan:
1. Run the following SQL query on the database:
   DELETE FROM tables_settings WHERE tablename = 'table_item_type';
2. Restart plack / memcached if using.
3. Open itemtypes.pl.
4. If there are fewer than 11 item types, create additional item types until there are more than 10, so that the next button can be used.
5. Click on the next button / link.
6. Notice that nothing happens.
7. Apply the patch.
8. Restart plack / memcached if using.
9. Reload itemtypes.pl.
10. Click on the next button / link.
11. Notice that the next page is displayed.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
I can reproduce the problem on ktd, after a restart_all and a
hard reload of itemtypes.pl. Patch fixes the problem.
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Olivier Hubert 2022-10-26 12:29:20 -04:00 committed by Tomas Cohen Arazi
parent 69a1c4a53a
commit e23d4d0e6a
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
View file

@ -203,7 +203,8 @@ function KohaTable(id_selector, dt_parameters, table_settings, add_filters) {
if ( table_settings ) {
if ( table_settings.hasOwnProperty('default_display_length') && table_settings['default_display_length'] != null ) {
new_parameters["pageLength"] = table_settings['default_display_length'];
// pageLength needs to be a number, not a string, or it can cause issues with DataTable's next button.
new_parameters["pageLength"] = parseInt(table_settings['default_display_length']);
}
if ( table_settings.hasOwnProperty('default_sort_order') && table_settings['default_sort_order'] != null ) {
new_parameters["order"] = [[ table_settings['default_sort_order'], 'asc' ]];