Browse Source
This patch tries to reorganise test files in the db_dependent directory: - Circulation_Branch.t has been moved to Circulation/Branch.t - Circulation_issuingrules.t has been moved to Circulation/CalcDateDue.t - Circulation_Issuingrule.t has been moved to Circulation/GetHardDueDate.t - Circulation_dateexpiry.t has been moved to Circulation/dateexpiry.t - Circulation_issue.t has been moved to Circulation/issue.t - Circulation_transfers.t has been moved to Circulation/transfers.t - Items_DelItem.t has been moved to Items/DelItem.t - BiblioObject.t has been moved to Koha/Biblio.t - Members_Attributes.t has been moved to Members/Attributes.t - Members_columns.t has been moved to Members/columns.t - Circulation_OfflineOperation.t has been moved to Circulation/OfflineOperation.t - Koha_template_plugin_KohaDates.t has been moved to Template/Plugin/KohaDates.t - Koha_template_plugin_Branches.t has been moved to Template/Plugin/Branches.t - Reports/Guided.t, ReportsGuided.t and Reports_Guided.t have been merged Test plan: Confirm that all the modified tests still pass Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>new_12478_elasticsearch
Brendan Gallagher
17 changed files with 266 additions and 356 deletions
@ -1,57 +0,0 @@ |
|||
#!/usr/bin/perl |
|||
|
|||
# Copyright 2013-2014 Equinox Software, Inc. |
|||
# |
|||
# This file is part of Koha. |
|||
# |
|||
# Koha is free software; you can redistribute it and/or modify it under the |
|||
# terms of the GNU General Public License as published by the Free Software |
|||
# Foundation; either version 3 of the License, or (at your option) any later |
|||
# version. |
|||
# |
|||
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY |
|||
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR |
|||
# A PARTICULAR PURPOSE. See the GNU General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU General Public License along |
|||
# with Koha; if not, see <http://www.gnu.org/licenses>. |
|||
|
|||
use Modern::Perl; |
|||
|
|||
use Test::More tests => 7; |
|||
|
|||
use C4::Context; |
|||
use Koha::Database; |
|||
|
|||
use t::lib::TestBuilder; |
|||
|
|||
BEGIN { |
|||
use_ok('Koha::Template::Plugin::Branches'); |
|||
} |
|||
|
|||
my $schema = Koha::Database->schema; |
|||
$schema->storage->txn_begin; |
|||
my $builder = t::lib::TestBuilder->new; |
|||
my $library = $builder->build({ |
|||
source => 'Branch', |
|||
}); |
|||
|
|||
my $plugin = Koha::Template::Plugin::Branches->new(); |
|||
ok($plugin, "initialized Branches plugin"); |
|||
|
|||
my $name = $plugin->GetName($library->{branchcode}); |
|||
is($name, $library->{branchname}, 'retrieved expected name for library'); |
|||
|
|||
$name = $plugin->GetName('__ANY__'); |
|||
is($name, '', 'received empty string as name of the "__ANY__" placeholder library code'); |
|||
|
|||
$name = $plugin->GetName(undef); |
|||
is($name, '', 'received empty string as name of NULL/undefined library code'); |
|||
|
|||
$library = $plugin->GetLoggedInBranchcode(); |
|||
is($library, '', 'no active library if there is no active user session'); |
|||
|
|||
C4::Context->_new_userenv('DUMMY_SESSION_ID'); |
|||
C4::Context->set_userenv(123, 'userid', 'usercnum', 'First name', 'Surname', 'MYLIBRARY', 'My Library', 0); |
|||
$library = $plugin->GetLoggedInBranchcode(); |
|||
is($library, 'MYLIBRARY', 'GetLoggedInBranchcode() returns active library'); |
|||
@ -1,85 +0,0 @@ |
|||
#!/usr/bin/perl |
|||
|
|||
use Modern::Perl; |
|||
|
|||
use Test::More tests => 13; |
|||
|
|||
use Koha::Database; |
|||
|
|||
use_ok('C4::Reports::Guided'); |
|||
|
|||
my $schema = Koha::Database->new->schema; |
|||
$schema->storage->txn_begin; |
|||
|
|||
$_->delete for Koha::AuthorisedValues->search({ category => 'XXX' }); |
|||
Koha::AuthorisedValue->new({category => 'LOC'})->store; |
|||
|
|||
{ # GetReservedAuthorisedValues tests |
|||
# This one will catch new reserved words not added |
|||
# to GetReservedAuthorisedValues |
|||
my %test_authval = ( |
|||
'date' => 1, |
|||
'branches' => 1, |
|||
'itemtypes' => 1, |
|||
'cn_source' => 1, |
|||
'categorycode' => 1, |
|||
'biblio_framework' => 1, |
|||
); |
|||
|
|||
my $reserved_authorised_values = GetReservedAuthorisedValues(); |
|||
is_deeply(\%test_authval, $reserved_authorised_values, |
|||
'GetReservedAuthorisedValues returns a fixed list'); |
|||
} |
|||
|
|||
{ |
|||
ok( IsAuthorisedValueValid('LOC'), |
|||
'User defined authorised value category is valid'); |
|||
|
|||
ok( ! IsAuthorisedValueValid('XXX'), |
|||
'Not defined authorised value category is invalid'); |
|||
|
|||
# Loop through the reserved authorised values |
|||
foreach my $authorised_value ( keys %{GetReservedAuthorisedValues()} ) { |
|||
ok( IsAuthorisedValueValid($authorised_value), |
|||
'\''.$authorised_value.'\' is a reserved word, and thus a valid authorised value'); |
|||
} |
|||
} |
|||
|
|||
{ # GetParametersFromSQL tests |
|||
|
|||
my $test_query_1 = " |
|||
SELECT date_due |
|||
FROM old_issues |
|||
WHERE YEAR(timestamp) = <<Year|custom_list>> AND |
|||
branchcode = <<Branch|branches>> AND |
|||
borrowernumber = <<Borrower>> |
|||
"; |
|||
|
|||
my @test_parameters_with_custom_list = ( |
|||
{ 'name' => 'Year', 'authval' => 'custom_list' }, |
|||
{ 'name' => 'Branch', 'authval' => 'branches' }, |
|||
{ 'name' => 'Borrower', 'authval' => undef } |
|||
); |
|||
|
|||
is_deeply( GetParametersFromSQL($test_query_1), \@test_parameters_with_custom_list, |
|||
'SQL params are correctly parsed'); |
|||
|
|||
# ValidateSQLParameters tests |
|||
my @problematic_parameters = (); |
|||
push @problematic_parameters, { 'name' => 'Year', 'authval' => 'custom_list' }; |
|||
is_deeply( ValidateSQLParameters( $test_query_1 ), |
|||
\@problematic_parameters, |
|||
'\'custom_list\' not a valid category' ); |
|||
|
|||
my $test_query_2 = " |
|||
SELECT date_due |
|||
FROM old_issues |
|||
WHERE YEAR(timestamp) = <<Year|date>> AND |
|||
branchcode = <<Branch|branches>> AND |
|||
borrowernumber = <<Borrower|LOC>> |
|||
"; |
|||
|
|||
is_deeply( ValidateSQLParameters( $test_query_2 ), |
|||
[], |
|||
'All parameters valid, empty problematic authvals list'); |
|||
} |
|||
@ -1,123 +0,0 @@ |
|||
#!/usr/bin/perl |
|||
|
|||
# This file is part of Koha. |
|||
# |
|||
# Koha is free software; you can redistribute it and/or modify it |
|||
# under the terms of the GNU General Public License as published by |
|||
# the Free Software Foundation; either version 3 of the License, or |
|||
# (at your option) any later version. |
|||
# |
|||
# Koha is distributed in the hope that it will be useful, but |
|||
# WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
# GNU General Public License for more details. |
|||
# |
|||
# You should have received a copy of the GNU General Public License |
|||
# along with Koha; if not, see <http://www.gnu.org/licenses>. |
|||
|
|||
use Modern::Perl; |
|||
|
|||
use Test::More tests => 18; |
|||
use Test::Warn; |
|||
use t::lib::TestBuilder; |
|||
|
|||
use C4::Context; |
|||
use Koha::Database; |
|||
|
|||
BEGIN { |
|||
use_ok('C4::Reports::Guided'); |
|||
} |
|||
can_ok( |
|||
'C4::Reports::Guided', |
|||
qw(save_report delete_report execute_query) |
|||
); |
|||
|
|||
my $schema = Koha::Database->new->schema; |
|||
$schema->storage->txn_begin; |
|||
my $builder = t::lib::TestBuilder->new; |
|||
|
|||
my $dbh = C4::Context->dbh; |
|||
$dbh->do(q|DELETE FROM saved_sql|); |
|||
$dbh->do(q|DELETE FROM saved_reports|); |
|||
|
|||
#Start tests |
|||
|
|||
#Test save_report |
|||
my $count = scalar @{ get_saved_reports() }; |
|||
is( $count, 0, "There is no report" ); |
|||
|
|||
my @report_ids; |
|||
foreach ( 1..3 ) { |
|||
my $id = $builder->build({ source => 'Borrower' })->{ borrowernumber }; |
|||
push @report_ids, save_report({ |
|||
borrowernumber => $id, |
|||
sql => "SQL$id", |
|||
name => "Name$id", |
|||
area => "area$id", |
|||
group => "group$id", |
|||
subgroup => "subgroup$id", |
|||
type => "type$id", |
|||
notes => "note$id", |
|||
cache_expiry => "null", |
|||
public => "null" |
|||
}); |
|||
$count++; |
|||
} |
|||
like( $report_ids[0], '/^\d+$/', "Save_report returns an id for first" ); |
|||
like( $report_ids[1], '/^\d+$/', "Save_report returns an id for second" ); |
|||
like( $report_ids[2], '/^\d+$/', "Save_report returns an id for third" ); |
|||
|
|||
is( scalar @{ get_saved_reports() }, |
|||
$count, "$count reports have been added" ); |
|||
|
|||
ok( 0 < scalar @{ get_saved_reports( $report_ids[0] ) }, "filter takes report id" ); |
|||
|
|||
#Test delete_report |
|||
is (delete_report(),undef, "Without id delete_report returns undef"); |
|||
|
|||
is( delete_report( $report_ids[0] ), 1, "report 1 is deleted" ); |
|||
$count--; |
|||
|
|||
is( scalar @{ get_saved_reports() }, $count, "Report1 has been deleted" ); |
|||
|
|||
is( delete_report( $report_ids[1], $report_ids[2] ), 2, "report 2 and 3 are deleted" ); |
|||
$count -= 2; |
|||
|
|||
is( scalar @{ get_saved_reports() }, |
|||
$count, "Report2 and report3 have been deleted" ); |
|||
|
|||
my $sth = execute_query('SELECT COUNT(*) FROM systempreferences', 0, 10); |
|||
my $results = $sth->fetchall_arrayref; |
|||
is(scalar @$results, 1, 'running a query returned a result'); |
|||
|
|||
my $version = C4::Context->preference('Version'); |
|||
$sth = execute_query( |
|||
'SELECT value FROM systempreferences WHERE variable = ?', |
|||
0, |
|||
10, |
|||
[ 'Version' ], |
|||
); |
|||
$results = $sth->fetchall_arrayref; |
|||
is_deeply( |
|||
$results, |
|||
[ [ $version ] ], |
|||
'running a query with a parameter returned the expected result' |
|||
); |
|||
|
|||
# for next test, we want to let execute_query capture any SQL errors |
|||
$dbh->{RaiseError} = 0; |
|||
my $errors; |
|||
warning_like { ($sth, $errors) = execute_query( |
|||
'SELECT surname FRM borrowers', # error in the query is intentional |
|||
0, 10 ) } |
|||
qr/^DBD::mysql::st execute failed: You have an error in your SQL syntax;/, |
|||
"Wrong SQL syntax raises warning"; |
|||
ok( |
|||
defined($errors) && exists($errors->{queryerr}), |
|||
'attempting to run a report with an SQL syntax error returns error message (Bug 12214)' |
|||
); |
|||
|
|||
is_deeply( get_report_areas(), [ 'CIRC', 'CAT', 'PAT', 'ACQ', 'ACC', 'SER' ], |
|||
"get_report_areas returns the correct array of report areas"); |
|||
|
|||
$schema->storage->txn_rollback; |
|||
Loading…
Reference in new issue