Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 8997: Unnecessary call to getAllLanguages

Browse source 
In C4/Language, getTranslatedLanguages calls getAllLanguage, passes it
to _build_languages_arrayref, that does nothing of it. Removing this
dead code will clean & reduce SQL overhead

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
I tried switching between languages and enabling and disabling
languages, and could not see any change with the patch applied.

Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
Paul Poulain 2012-10-31 18:22:14 +01:00 committed by Jared Camins-Esakov
parent 90ddc20c07
commit e2cf59ac58
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
C4/Languages.pm
View file

@ -119,7 +119,6 @@ Returns a reference to an array of hashes:
sub getTranslatedLanguages {
my ($interface, $theme, $current_language, $which) = @_;
my $htdocs;
my $all_languages = getAllLanguages();
my @languages;
my @enabled_languages;
@ -161,7 +160,7 @@ sub getTranslatedLanguages {
$seen{$_}++ for @languages;
@languages = keys %seen;
}
return _build_languages_arrayref($all_languages,\@languages,$current_language,\@enabled_languages);
return _build_languages_arrayref(\@languages,$current_language,\@enabled_languages);
}
=head2 getAllLanguages
@ -276,7 +275,7 @@ FIXME: this could be rewritten and simplified using map
=cut
sub _build_languages_arrayref {
my ($all_languages,$translated_languages,$current_language,$enabled_languages) = @_;
my ($translated_languages,$current_language,$enabled_languages) = @_;
my @translated_languages = @$translated_languages;
my @languages_loop; # the final reference to an array of hashrefs
my @enabled_languages = @$enabled_languages;