Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Revert "Bug 17902: Fix possible SQL injection in serials editing"

Browse source 
This reverts commit 8924439054.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Kyle Hall 2017-01-30 11:52:56 +00:00
parent 8924439054
commit e2d1bafa22
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
C4/Serials.pm
View file

@ -739,20 +739,19 @@ sub GetSerials2 {
return unless ($subscription and @$statuses); return unless ($subscription and @$statuses);
my $statuses_string = join ',', @$statuses;
my $dbh = C4::Context->dbh; my $dbh = C4::Context->dbh;
my $query = q| my $query = qq|
SELECT serialid,serialseq, status, planneddate, publisheddate, SELECT serialid,serialseq, status, planneddate, publisheddate,
publisheddatetext, notes, routingnotes publisheddatetext, notes, routingnotes
FROM serial FROM serial
WHERE subscriptionid=? WHERE subscriptionid=$subscription AND status IN ($statuses_string)
|
. q| AND status IN (| . join( ",", ('?') x @$statuses ) . ")" . q|)|
. q|
ORDER BY publisheddate,serialid DESC ORDER BY publisheddate,serialid DESC
|; |;
$debug and warn "GetSerials2 query: $query"; $debug and warn "GetSerials2 query: $query";
my $sth = $dbh->prepare($query); my $sth = $dbh->prepare($query);
$sth->execute( $subscription, @$statuses ); $sth->execute;
my @serials; my @serials;
while ( my $line = $sth->fetchrow_hashref ) { while ( my $line = $sth->fetchrow_hashref ) {