Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 36708: Fix column index for processing No automatic renewal after

Browse source 
To test:
1- Find or create a circulation rule with a 'Holds allowed (total)' limit of 3 (or another number) and no value in 'No automatic renewal after (hard limit)'
2- Select to edit the rule, and note that 'No automatic renewal after (hard limit)' box in the editing line is now populated with a date
3- Note also that 'Holds allowed (total)' is empty in your editing line
4- If you save your edits without clearing the new 'No automatic renewal after (hard limit)' date, it will save as part of the rule. Also, 'Holds allowed (total)' will save as Unlimited unless you re-add your numerical value.
5- APPLY PATCH
6- Try again, the values should save corrected and not erroneously fill the No automatic renewal after (hard limit) column.

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Lucas Gass 2024-04-29 15:18:26 +00:00 committed by Fridolin Somers
parent 64ebafd69b
commit e3a04f73a2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
View file

@ -1500,7 +1500,7 @@
hardduedate = fp.parseDate( hardduedate, flatpickr_dateformat_string ); hardduedate = fp.parseDate( hardduedate, flatpickr_dateformat_string );
if( hardduedate) fp.setDate( hardduedate, 1 ); if( hardduedate) fp.setDate( hardduedate, 1 );
} }
} else if ( i == 26 ) { } else if ( i == 25 ) {
// specific processing for No automatic renewal after (hard limit) // specific processing for No automatic renewal after (hard limit)
var renewdate = itm_text; var renewdate = itm_text;
if (renewdate) { if (renewdate) {