Browse Source
If a library is using Talking Tech for phone notices, any waiting hold phone notice will show up twice! This is because Koha generates on at the time the hold is set to waiting, and then the cronjob TalkingTech_itiva_outbound.pl generates it's own notice as well. The former notice will always have a status of 'pending', as the TalkingTech_itiva_inbound.pl script will update the notice the outbound script created. The solution is to prevent Koha from creating a phone notice for waiting holds if TT is enabled, and let the cron script do it. Test Plan: 1) Enable Talking Tech from the system preferences 2) Set a hold waiting phone notice in the notices and slips editor 3) Choose a patron, enable hold phone notices for that patron 4) Place a hold for a patron, and check it in so it's marked as waiting 5) Note the phone notice generated for the patron 6) Apply this patch 7) Repeat step 4 8) Note that this time, a phone hold waiting notice is not generated Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amends condition with an additional or statement. Shoudn't affect anything but phone notices. Change appears logical. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>3.18.x
1 changed files with 6 additions and 4 deletions
Loading…
Reference in new issue