Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 20216: Correctly populate values in itemtype editor

Browse source 
Caused by a bad merge conflict on bug 12768.

To test:
1 - Edit an item type, define a replacement cost,processing fee, and
remote image url
2 - Save the item type
3 - Values are correct in list
4 - Edit again
5 - note values in fields are not populated
6 - Save itemtype, values are lost
7 - Apply patch
8 - Repeat 1-4
9 - Values should be correctly populated and saved now

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Bug 20216: (follow-up) - Fix other use of remote_image

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2018-02-15 17:05:29 +00:00 committed by Jonathan Druart
parent f0e29fc46f
commit e4301a52b8
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
View file

@ -195,14 +195,14 @@ Item types administration
<ul> <ul>
<li> <li>
<label for="remote_image_check"> Remote image:</label> <label for="remote_image_check"> Remote image:</label>
[% IF remote_image %] [% IF itemtype.imageurl %]
<input type="radio" id="remote_image_check" name="image" value="remoteImage" checked="checked" /> <input type="radio" id="remote_image_check" name="image" value="remoteImage" checked="checked" />
[% ELSE %] [% ELSE %]
<input type="radio" id="remote_image_check" name="image" value="remoteImage" /> <input type="radio" id="remote_image_check" name="image" value="remoteImage" />
[% END %] [% END %]
<input type="text" name="remoteImage" size="48" maxlength="200" value="[% remote_image %]" onmousedown="document.getElementById('remote_image_check').checked = true;" /> <input type="text" name="remoteImage" size="48" maxlength="200" value="[% itemtype.imageurl %]" onmousedown="document.getElementById('remote_image_check').checked = true;" />
[% IF ( remote_image ) %] [% IF itemtype.imageurl %]
<img src="[% remote_image %]" alt="" /> <img src="[% itemtype.imageurl %]" alt="" />
[% END %] [% END %]
</li> </li>
</ul> </ul>
@ -235,11 +235,11 @@ Item types administration
</li> </li>
<li> <li>
<label for="defaultreplacecost">Default replacement cost: </label> <label for="defaultreplacecost">Default replacement cost: </label>
<input type="text" id="defaultreplacecost" name="defaultreplacecost" size="10" value="[% defaultreplacecost %]" /> <input type="text" id="defaultreplacecost" name="defaultreplacecost" size="10" value="[% itemtype.defaultreplacecost %]" />
</li> </li>
<li> <li>
<label for="processfee">Processing fee (when lost): </label> <label for="processfee">Processing fee (when lost): </label>
<input type="text" id="processfee" name="processfee" size="10" value="[% processfee %]" /> <input type="text" id="processfee" name="processfee" size="10" value="[% itemtype.processfee %]" />
</li> </li>
<li> <li>
<label for="checkinmsg">Checkin message: </label> <label for="checkinmsg">Checkin message: </label>