Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25261: (QA follow-up) Catch check in SIP Checkin

Browse source 
Test plan
1/ Enable the feature as per previous patches
2/ Attempt to return an item with materials attached via a SIP unit
3/ Note that the return is blocked with an alert type of '99'
4/ Signoff

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2020-08-13 16:44:28 +01:00 committed by Jonathan Druart
parent 334c8e94c1
commit e510386879
1 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
C4/SIP/ILS/Transaction/Checkin.pm
View file

@ -16,6 +16,7 @@ use C4::Debug;
use C4::Items qw( ModItemTransfer );
use C4::Reserves qw( ModReserveAffect );
use Koha::DateUtils qw( dt_from_string );
use Koha::Items;
use parent qw(C4::SIP::ILS::Transaction);
@ -74,8 +75,21 @@ sub do_checkin {
$return_date = dt_from_string($return_date);
}
my ( $return, $messages, $issue, $borrower );
my $item = Koha::Items->find( { barcode => $barcode } );
my $human_required = 0;
if ( C4::Context->preference("CircConfirmItemParts")
&& defined($item)
&& $item->materials )
{
$human_required = 1;
$messages->{additional_materials} = 1;
}
$debug and warn "do_checkin() calling AddReturn($barcode, $branch)";
my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, $return_date);
( $return, $messages, $issue, $borrower ) =
AddReturn( $barcode, $branch, undef, $return_date )
unless $human_required;
if ( $checked_in_ok ) {
delete $messages->{ItemLocationUpdated};
@ -87,6 +101,9 @@ sub do_checkin {
# biblionumber, biblioitemnumber, itemnumber
# borrowernumber, reservedate, branchcode
# cancellationdate, found, reservenotes, priority, timestamp
if ($messages->{additional_materials}) {
$self->alert_type('99');
}
if( $messages->{DataCorrupted} ) {
$self->alert_type('98');
}