Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 16219: (QA follow-up) Tiny regex change

Browse source 
The parameter <<>> does not work. There should be text inside.
The construction .*? does not look good completely.
Replacing it by the stricter [^>]+ So, no greater than's and at least one.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2019-08-09 10:17:41 +00:00 committed by Martin Renvoize
parent 52587b4319
commit e66ccaa3a7
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
misc/cronjobs/runreport.pl
View file

@ -265,7 +265,7 @@ foreach my $report_id (@ARGV) {
}
# convert SQL parameters to placeholders
my $params_needed = ( $sql =~ s/(<<.*?>>)/\?/g );
my $params_needed = ( $sql =~ s/(<<[^>]+>>)/\?/g );
die("You supplied ". scalar @params . " parameter(s) and $params_needed are required by the report") if scalar @params != $params_needed;
my ($sth) = execute_query( $sql, undef, undef, \@params, $report_id );