Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30493: Pending archived suggestions appear on intranet home page

Browse source 
If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed.

WITHOUT PATCH:
1. Go to Acquisitions > Suggestions
2. Click on New purchase suggestion
3. Fill in the form (title only is fine)
4. Click on Submit your suggestion
5. Go to the home page (click the Koha logo)
   --> Notice it says that there is 1 pending suggestion
6. Go to Acquisitions
   --> Notice it says that there is 1 pending suggestion
7. Go to Suggestions
8. Click on the up arrow to the right of the Edit button and choose Archive
   --> There are no more pending suggestions
9. Go to the home page (click the Koha logo)
   --> Notice it says that there is 1 pending suggestion
10. Go to Acquisitions
   --> Notice it says that there is 1 pending suggestion

The search function was fetching suggestions without considering the
"archived" field. I now pick only suggestion that are pending AND not
archived.

WITH PATCH:
9. Go to the home page (click the Koha logo)
   --> Notice it says that there is no pending suggestion
10. Go to Acquisitions
   --> Notice it says that there is no pending suggestion

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Baptiste Wojtkowski 2024-06-13 15:36:18 +02:00 committed by Katrin Fischer
parent f567d41b91
commit e87f4cd550
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
acqui/acqui-home.pl
View file

@ -53,7 +53,7 @@ if( C4::Context->only_my_library ){
my $local_pendingsuggestions_count = Koha::Suggestions->search({ status => "ASKED", branchcode => C4::Context->userenv()->{'branch'} })->count(); my $local_pendingsuggestions_count = Koha::Suggestions->search({ status => "ASKED", branchcode => C4::Context->userenv()->{'branch'} })->count();
$template->param( suggestions_count => $local_pendingsuggestions_count ); $template->param( suggestions_count => $local_pendingsuggestions_count );
} else { } else {
my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED" }); my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED", archived => 0 });
my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count(); my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count();
my $pendingsuggestions_count = $pendingsuggestions->count(); my $pendingsuggestions_count = $pendingsuggestions->count();
$template->param( $template->param(

2
mainpage.pl
View file

@ -89,7 +89,7 @@ if( C4::Context->only_my_library ){
my $local_pendingsuggestions_count = Koha::Suggestions->search({ status => "ASKED", branchcode => C4::Context->userenv()->{'branch'} })->count(); my $local_pendingsuggestions_count = Koha::Suggestions->search({ status => "ASKED", branchcode => C4::Context->userenv()->{'branch'} })->count();
$template->param( pendingsuggestions => $local_pendingsuggestions_count ); $template->param( pendingsuggestions => $local_pendingsuggestions_count );
} else { } else {
my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED" }); my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED", archived => 0 });
my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count(); my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count();
my $pendingsuggestions_count = $pendingsuggestions->count(); my $pendingsuggestions_count = $pendingsuggestions->count();
$template->param( $template->param(