Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 11505: fix untranslatable table headers in Label batch manager

Browse source 
The label batch manager script hard-codes the table header cell labels
in order to pass them to an HTML-building function. This obviously isn't
the best solution for internationalization, but picking the whole scheme
apart would be very complicated.

Instead this patch uses a SWITCH statement to check for each possible
case and outputs the correct translatable string for each.

To test, apply the patch and run "perl translate update" for any
translation. Check the revised po file and confirm that the new strings
are present. View the label batch edit page and confirm that the table
headings look correct: Tools -> Labels -> Manage batches -> Edit batch.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests.
Similar fixes are probably needed for other pages of the labels
modules.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Owen Leonard 2014-01-10 15:46:29 -05:00 committed by Galen Charlton
parent f2c6142994
commit e8f5ee9eef
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt
View file

@ -197,7 +197,20 @@
[% IF ( table_loo.header_fields ) %]
<tr>
[% FOREACH header_field IN table_loo.header_fields %]
<th>[% header_field.field_label %]</th>
[% SWITCH header_field.field_label -%]
[% CASE "Label Number" -%]
<th>Label number</th>
[% CASE "Summary" -%]
<th>Summary</th>
[% CASE "Item Type" %]
<th>Item type</th>
[% CASE "Barcode" %]
<th>Barcode</th>
[% CASE "Select" -%]
<th>Select</th>
[% CASE %]
<th>[% header_field.field_label %]</th>
[% END -%]
[% END %]
</tr>
[% ELSE %]