Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35628: Unit tests for addition to tickets API

Browse source 
This patch updates the unit test for the ticket_updates api to catch
both the missing test 'state' for the existing state change
functionality and also the new 'status' functionality introduced with
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Martin Renvoize 2024-04-25 16:10:24 +01:00 committed by Katrin Fischer
parent 84f3948c2a
commit e968e80dd9
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
t/db_dependent/api/v1/ticket_updates.t
View file

@ -118,7 +118,7 @@ subtest 'list_updates() tests' => sub {
subtest 'add_update() tests' => sub {
plan tests => 34;
plan tests => 37;
$schema->storage->txn_begin;
@ -145,7 +145,12 @@ subtest 'add_update() tests' => sub {
my $ticket = $builder->build_object(
{
class => 'Koha::Tickets',
value => { reporter_id => $patron->id }
value => {
reporter_id => $patron->id,
resolver_id => undef,
resolved_date => undef,
status => 'new'
}
}
);
my $ticket_id = $ticket->id;
@ -233,7 +238,9 @@ subtest 'add_update() tests' => sub {
);
$THE_notice->delete;
# Check that state change triggers correct notice
$update->{state} = 'resolved';
$update->{status} = 'TEST';
$update_id =
$t->post_ok(
"//$userid:$password@/api/v1/tickets/$ticket_id/updates" => json =>
@ -253,5 +260,19 @@ subtest 'add_update() tests' => sub {
'Notice queued was a TICKET_RESOLVED for status changing update'
);
# Check that state change is carried over to ticket
$ticket = $ticket->get_from_storage;
is(
$ticket->resolver_id, $librarian->id,
"Ticket was given resolver_id matching the librarian id of the update when state was changed to 'resolved'"
);
isnt( $ticket->resolved_date, undef, "Ticket was given resolved_date when state was updated to 'resolved'" );
# Check that status change is carried over to ticket
is(
$ticket->status, 'TEST',
"Ticket status was updated in line with status change in update"
);
$schema->storage->txn_rollback;
};