Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 2553: Additional patch for the branch drop-down in Existing Holds.

Browse source 
Improves previous patch through the use of GetBranchesLoop. Also adds highlighting to the Existing holds table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This commit is contained in:
Garry Collum 2009-07-22 21:07:16 -04:00 committed by Galen Charlton
parent 77e4b2ce9d
commit e997a4a11c
2 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl
View file

@ -505,7 +505,7 @@ function checkMultiHold() {
<th>Details</th>
</tr>
<!-- TMPL_LOOP Name="reserveloop" -->
<tr>
<!-- TMPL_UNLESS Name="__odd__" --><tr class="highlight"><!-- TMPL_ELSE --><tr><!-- /TMPL_UNLESS -->
<td>
<input type="hidden" name="borrowernumber" value="<!-- TMPL_VAR NAME="borrowernumber" -->" />
<input type="hidden" name="biblionumber" value="<!-- TMPL_VAR NAME="biblionumber" -->" />
@ -539,9 +539,9 @@ function checkMultiHold() {
<select name="pickup">
<!-- TMPL_LOOP Name="branchloop" -->
<!-- TMPL_IF Name="selected" -->
<option value="<!-- TMPL_VAR NAME="branch" -->" selected="selected">
<option value="<!-- TMPL_VAR NAME="value" -->" selected="selected">
<!-- TMPL_ELSE -->
<option value="<!-- TMPL_VAR NAME="branch" -->">
<option value="<!-- TMPL_VAR NAME="value" -->">
<!-- /TMPL_IF -->
<!-- TMPL_VAR NAME="branchname" -->
</option>

10
reserve/request.pl
View file

@ -446,14 +446,6 @@ foreach my $biblionumber (@biblionumbers) {
}
);
}
my @branchloop;
foreach my $br ( sort {$branches->{$a}->{'branchname'} cmp $branches->{$b}->{'branchname'}} keys %$branches ) {
my %abranch;
$abranch{'selected'} = ( $br eq $res->{'branchcode'} );
$abranch{'branch'} = $br;
$abranch{'branchname'} = $branches->{$br}->{'branchname'};
push( @branchloop, \%abranch );
}
if ( ( $res->{'found'} eq 'W' ) ) {
my $item = $res->{'itemnumber'};
@ -497,7 +489,7 @@ foreach my $biblionumber (@biblionumbers) {
$reserve{'ccode'} = $res->{'ccode'};
$reserve{'barcode'} = $res->{'barcode'};
$reserve{'priority'} = $res->{'priority'};
$reserve{'branchloop'} = \@branchloop;
$reserve{'branchloop'} = GetBranchesLoop($res->{'branchcode'});
$reserve{'optionloop'} = \@optionloop;
push( @reserveloop, \%reserve );