Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10836: (follow-up) improve display toggles on the OPAC hold request form

Browse source 
This patch improves the the toggles for displaying and hiding the hold
options div and the toggles for displaying the table of specific copies
to request.  It also moves the copy table into the hold options div.

To test:

[1] Select a single title in the OPAC and click on the place hold
    button.
[2] Click 'Show more options', and select a specific copy to request.
[3] Click 'Hide options'.  Verify that the hold options, including the
    copy table, are hidden.
[4] Click 'Show more options'.  Verify that the specific copy radio
    button is still selected and that the copy selected in step to is
    selected.
[5] Enable DisplayMultiPlaceHold and select several titles to
    request.
[6] Do steps 2, 3, and 4 on various titles on the request form.  Verify
    that toggling the options link for one title on the form affects
    the visibility only for that title.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

While signing off I removed one <br /> tag and corrected a float in the
CSS. This helps keep the border between individual hold listings.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Galen Charlton 2013-09-27 15:55:29 +00:00
parent 74553d7fef
commit e9c77aaf3a
2 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
koha-tmpl/opac-tmpl/prog/en/css/opac.css
View file

@ -3064,6 +3064,7 @@ padding: 0.1em 0;
.holdrow fieldset {
border : 0;
margin : 0;
float: none;
}
.hold-options {
clear : both;

13
koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
View file

@ -108,7 +108,6 @@
if (!changeSelection(newCopiesRowId, true)) {
return false;
}
$(".copiesrow:not(" + newCopiesRowId + ")").hide();
// Show the specific copy table for this radio button.
$(newCopiesRowId).show();
@ -126,7 +125,7 @@
}
// Hide the copies table row
$(".copiesrow").hide();
$(newCopiesRowId).hide();
});
// When 'Place Hold' button is clicked
@ -182,12 +181,7 @@
e.preventDefault();
toggleLink = $(this);
var optionsID = this.id.replace("toggle-hold-options-","");
var copiesRow = $("#copiesrow_"+optionsID)
$("#hold-options-"+optionsID).toggle(0, function() {
if( copiesRow.is(':visible') ){
$("#reqany_"+optionsID).prop("checked",true);
copiesRow.hide();
}
toggleLink.text($(this).is(':visible') ? _("Hide options") : _("Show more options"));
});
});
@ -468,9 +462,6 @@
[% END %]
[% END %]
</ul>
</div>
</fieldset>
<br style="clear:both" />
[% IF ( OPACItemHolds ) %]
[% IF ( bibitemloo.holdable ) %]
@ -552,6 +543,8 @@
[% END %]<!-- bib_available -->
[% END %]<!-- OPACItemHolds -->
</div>
</fieldset>
[% END %]
[% END %] <!-- if message -->