Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31799: (follow-up) Tidy up and fix duplicate barcode handling

Browse source 
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Agustin Moyano 2023-01-03 16:09:10 -03:00 committed by Tomas Cohen Arazi
parent 51d50810fa
commit ead5f5c2f4
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 9 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
Koha/REST/V1/Biblios.pm
View file

@ -431,32 +431,20 @@ sub update_item {
$item->set_from_api($body);
my $barcodeSearch;
$barcodeSearch = Koha::Items->search( { barcode => $body->{external_id} } ) if defined $body->{external_id};
if ( $barcodeSearch
&& ($barcodeSearch->count > 1
|| ($barcodeSearch->count == 1
&& $barcodeSearch->next->itemnumber != $item->itemnumber
)
)
)
{
return $c->render(
status => 400,
openapi => { error => "Barcode not unique" }
);
}
my $storedItem = $item->store;
$storedItem->discard_changes;
$item->store->discard_changes;
$c->render(
status => 200,
openapi => $storedItem->to_api
openapi => $item->to_api
);
}
catch {
if ( blessed $_ and $_->isa('Koha::Exceptions::Object::DuplicateID') ) {
return $c->render(
status => 409,
openapi => { error => 'Duplicate barcode.' }
);
}
$c->unhandled_exception($_);
}
}

2
t/db_dependent/api/v1/biblios.t
View file

@ -1792,7 +1792,7 @@ subtest 'update_item() tests' => sub {
$t->put_ok("//$userid:$password@/api/v1/biblios/$biblio_id/items/$item_id" => json => {
external_id => $other_item->barcode,
})
->status_is(400, 'Barcode not unique');
->status_is(409, 'Barcode not unique');
$t->put_ok("//$userid:$password@/api/v1/biblios/$biblio_id/items/$item_id" => json => {
replacement_price => 30,