Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18730: Batch Mod Edit <label> HTML validation fails

Browse source 
[tag] [reply] [−] Description M. Tompsett 2017-06-05 16:30:21 UTC
Know the barcode of an existing item.
Home -> Tools -> Batch Item Modification
Enter the barcode
Click
View Page source
select and copy it into validator.w3.org direct input.
There will be complaints about <labels>.

Apply this patch

refresh the page.
select and copy it into validator.w3.org direct input.
There will be no complaints about <labels>.

This is intended to be a highly focused HTML bug, as the
missing form tag which will fix the <div> issues at the bottom
is corrected on bug 18710.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
This commit is contained in:
Mark Tompsett 2017-06-05 12:24:07 -04:00 committed by Jonathan Druart
parent e426da4e00
commit eb0a67ea10
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
View file

@ -193,15 +193,15 @@ $(document).ready(function(){
[% FOREACH ite IN item %]
<li>
<div class="subfield_line" style="[% ite.visibility %]" id="subfield[% ite.tag %][% ite.subfield %][% ite.random %]">
[% SET mv = ite.marc_value %]
[% IF ( ite.mandatory ) %]
<label class="required" for="tag_[% ite.tag %]_subfield_[% ite.subfield %]_[% ite.random %]">
<label class="required" for="[%- mv.id -%]">
[% ELSE %]
<label for="tag_[% ite.tag %]_subfield_[% ite.subfield %]_[% ite.random %]">
<label for="[%- mv.id -%]">
[% END %]
[% ite.subfield %] - [% ite.marc_lib %]
</label>
[% SET mv = ite.marc_value %]
[% IF ( mv.type == 'select' ) -%]
<select name="[%- mv.name -%]" id="[%- mv.id -%]" size="1" tabindex="1" class="input_marceditor">
[%- FOREACH aval IN mv.values %]