Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31154: (QA follow-up) Fix UI form builder

Browse source 
The change in batchMod.pl is not needed when we fix the builder.
But we could at least add a comment there!

Note that passing the biblionumber of the first item does not
make sense since we are modifying items from several biblio
records normally. We most probably do not want this MARC
record's itemcallnumber (via the syspref) in all our items.

Test plan:
Test batchMod with and without the Populate fields checkbox.
Fill syspref 'itemcallnumber' with e.g. 084a.
Check Populate, and try again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2022-09-16 08:58:51 +00:00 committed by Tomas Cohen Arazi
parent 355ab980cc
commit eb29243140
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Koha/UI/Form/Builder/Item.pm
View file

@ -162,7 +162,7 @@ sub generate_subfield_form {
my $CNsubfields =
substr( $pref_itemcallnumber_part, 3 ); # Any and all subfields
$CNsubfields = undef if $CNsubfields eq '';
my $temp2 = $marc_record->field($CNtag);
my $temp2 = $marc_record ? $marc_record->field($CNtag) : undef;
next unless $temp2;
$value = $temp2->as_string( $CNsubfields, ' ' );
@ -314,7 +314,7 @@ sub generate_subfield_form {
);
my $pars = {
dbh => $dbh,
record => $marc_record,
record => $marc_record, #Note: could be undefined
tagslib => $tagslib,
id => $subfield_data{id},
};
@ -564,7 +564,7 @@ sub edit_form {
value => $value,
tagslib => $tagslib,
libraries => $libraries,
marc_record => $marc_record,
marc_record => $marc_record, #Note: could be undefined
restricted_edition => $restricted_edition,
prefill_with_default_values => $prefill_with_default_values,
branch_limit => $branch_limit,

4
tools/batchMod.pl
View file

@ -265,9 +265,7 @@ if ($op eq "show"){
# Getting list of subfields to keep when restricted batchmod edit is enabled
my @subfields_to_allow = $restrictededition ? split ' ', C4::Context->preference('SubfieldsToAllowForRestrictedBatchmod') : ();
$biblionumber = Koha::Items->find($itemnumbers[0])->unblessed->{biblionumber} if $itemnumbers[0];
my $subfields = Koha::UI::Form::Builder::Item->new(
{ biblionumber => $biblionumber } )->edit_form(
my $subfields = Koha::UI::Form::Builder::Item->new->edit_form( # NOTE: We are not passing a biblionumber intentionally !
{
restricted_editition => $restrictededition,
(