Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15339: TestBuilder warnings (code)

Browse source 
Makes TestBuilder::build() alert the user when unreognized
parameters are passed, which happens when the user supplies
the column values directly, forgetting the 'value' hash.

This patch holds the code changes. Examples of the kind of
errors that it catches are in the tests (separate patch).

Sponsored-By: Halland County Library

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Persson 2015-12-08 20:55:01 +01:00 committed by Jonathan Druart
parent 0c6538f033
commit ebd1039bbd
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
t/lib/TestBuilder.pm
View file

@ -89,6 +89,9 @@ sub build {
my $source = $params->{source} || return;
my $value = $params->{value};
my @unknowns = grep( !/source|value|only_fk/, keys %{ $params });
carp "Unknown parameter(s): ", join( ', ', @unknowns ) if scalar @unknowns;
my $col_values = $self->_buildColumnValues({
source => $source,
value => $value,